Re: [LTP] [PATCH v2 2/2] hugeshmctl03: Mark struct tcase and several functions as static

[Avinesh Kumar <akumar@suse.de>]

Hi Yang,

Changes looks fine, but I see that there are still make-check warnings for
both these tests. You may want to fix them also or maybe another commit.

Reviewed-by: Avinesh Kumar <akumar@suse.de>
for both the patches.

On Friday, August 25, 2023 5:05:36 PM IST Yang Xu wrote:
> To follow LTP conventions.
> 
> Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> ---
>  testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
> b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c index
> 21ec6bf78..61e9704bb 100644
> --- a/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
> +++ b/testcases/kernel/mem/hugetlb/hugeshmctl/hugeshmctl03.c
> @@ -44,7 +44,7 @@ static struct shmid_ds buf;
>  static uid_t ltp_uid;
>  static char *ltp_user = "nobody";
> 
> -struct tcase {
> +static struct tcase {
>  	int *shmid;
>  	int cmd;
>  	struct shmid_ds *sbuf;
> @@ -97,7 +97,7 @@ static void do_child(void)
>  	}
>  }
> 
> -void setup(void)
> +static void setup(void)
>  {
>  	long hpage_size;
> 
> @@ -118,7 +118,7 @@ void setup(void)
>  	ltp_uid = getuserid(ltp_user);
>  }
> 
> -void cleanup(void)
> +static void cleanup(void)
>  {
>  	rm_shm(shm_id_1);
>  }


--
Regards,
Avinesh



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp