Linux Test Project
 help / color / mirror / Atom feed
From: Sachin Sant <sachinp@linux.ibm.com>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v12 1/8] fs/acl: Add ACL_USER_OBJ permission test
Date: Wed, 29 Jul 2026 19:22:31 +0530	[thread overview]
Message-ID: <28415772-b9ba-481f-8a17-ceb5ef58ac61@linux.ibm.com> (raw)
In-Reply-To: <amnxF9DZ5u2UYL95@yuki.lan>



On 29/07/26 5:54 pm, Cyril Hrubis wrote:
> Hi!
> I've cleaned up the patchset and pushed all the acl_* tests, thanks.
>
> We already have xattr tests in syscalls/{set,get}_xattr that cover basic
> xattr operations I haven't xattr_test01 for that reason. If coverage is
> lacking there the xattr tests should be put there.
Thank you.
> The main changes:
>
> Added SAFE_ACL_SET_FILE() since the code to handle EOPNOTSUPP was
> repeated in each test. I've also weeded out some of the cleanup, there
> is no point in unlinking files or freeing memory before we call
> tst_brk() since that will be handled by the test cleanup and OS process
> memory teardown.
>
> Also weeded out the file removal in various branches in the middle of
> the test and in the test setup(). Each test cleans up the files at the
> start of the test function. With that there is no point in doing the
> cleanup anywhere else but cleanup().
>

-- 
Thanks
- Sachin



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-07-29 13:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16  4:54 [LTP] [PATCH v12 0/8] Convert shell-based ACL test (tacl_xattr.sh) to C Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 1/8] fs/acl: Add ACL_USER_OBJ permission test Sachin Sant
2026-06-16  8:39   ` [LTP] " linuxtestproject.agent
2026-07-29 12:24   ` [LTP] [PATCH v12 1/8] " Cyril Hrubis
2026-07-29 13:52     ` Sachin Sant [this message]
2026-06-16  4:54 ` [LTP] [PATCH v12 2/8] fs/acl: Add ACL mask interaction tests Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 3/8] fs/acl: Add ACL_OTHER permission test Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 4/8] fs/acl: Add default ACL inheritance test Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 5/8] fs/acl: Add chmod/chown ACL interaction tests Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 6/8] fs/acl: Add ACL symlink operations test Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 7/8] fs/acl: Add extended attributes test Sachin Sant
2026-06-16  4:54 ` [LTP] [PATCH v12 8/8] fs/acl: Remove old shell-based ACL test Sachin Sant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28415772-b9ba-481f-8a17-ceb5ef58ac61@linux.ibm.com \
    --to=sachinp@linux.ibm.com \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox