public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] syscalls/execveat03: Fix compiler errors
Date: Wed, 22 Aug 2018 02:49:23 -0400 (EDT)	[thread overview]
Message-ID: <290094759.41782706.1534920563792.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1534902864-19343-1-git-send-email-yangx.jy@cn.fujitsu.com>


----- Original Message -----
> According to open(2) and linkat(2) manpages, O_PATH and AT_EMPTY_PATH
> flags were added since kernel v2.6.39, so these undefined flags led
> to the following errors on older kernels(e.g. v2.6.32):
> ---------------------------------------------------------
> execveat03.c:66: error: ‘O_PATH’ undeclared (first use in this function)
> execveat03.c:69: error: ‘AT_EMPTY_PATH’ undeclared (first use in this
> function)
> ---------------------------------------------------------
> 
> 1) Add AT_EMPTY_PATH into lapi/fcntl.h
> 2) Include lapi/fcntl.h in execveat03.c
> 
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>

Pushed.

We could add also minimum kernel version check, but since test
is using ltp_syscall(), it handles ENOSYS. I'll leave it as it
is for now.

Thanks,
Jan

      reply	other threads:[~2018-08-22  6:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-20  4:49 [LTP] [PATCH] syscalls/execveat03: Fix compiler errors Xiao Yang
2018-08-21 12:02 ` Jan Stancek
2018-08-22  1:17   ` Xiao Yang
2018-08-22  1:54   ` [LTP] [PATCH v2] " Xiao Yang
2018-08-22  6:49     ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=290094759.41782706.1534920563792.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox