public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Andrea Cervesato via ltp <ltp@lists.linux.it>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 07/31] tlibio.c: Remove UCLINUX
Date: Fri, 12 Apr 2024 11:08:13 +0200	[thread overview]
Message-ID: <2edd5dee-77c3-45c7-a195-3fa5ff38282a@suse.com> (raw)
In-Reply-To: <Zhj3laSMKRVUyg7C@yuki>

Hi!

On 4/12/24 10:57, Cyril Hrubis wrote:
> Hi!
>>>> IMHO you are wrong here. IMHO uCLinux-ng [1], still used libc (used in Buildroot
>>>> and openembedded). And log in e5e938f4b7 (2009) suggests that it's about libc.
>>>> But the question is whether it's still needed. I could try to remove these and
>>>> test, but as a separate effort.
>>> You are right, these should be converted into configure checks later on.
>>>
>>> And the tlibio should probably be rewritten completely. So let's keep
>>> the patch as it is.
>>>
>> I started to rewrite part of that library when I was working on
>> growfiles test rewrite, but the complexity of it, the amount of nested
>> statements and macro directives made me crazy.
>> Waiting for a better moment to restart rewriting it, but work is on-going.
> Maybe it would be better to do this in a steps, first remove everything
> that is inside the ifdefs for hpux, sgi etc. and only then start working
> with the actual code...
>
Well that's the easiest part. growfiles has a really huge amount of bad 
code, it's the biggest in the whole LTP suite and (unfortunately) it's a 
really important one.
It will take a bit...probably it will be incremental.

Andrea


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2024-04-12  9:08 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-11 14:29 [LTP] [PATCH 00/31] Remove UCLINUX (nommu support) from LTP legacy C API Petr Vorel
2024-04-11 14:29 ` [LTP] [PATCH 01/31] m4: Remove UCLINUX (nommu detection) Petr Vorel
2024-04-11 14:29 ` [LTP] [PATCH 02/31] make: Remove WITH_POWER_MANAGEMENT_TESTSUITE Petr Vorel
2024-04-11 14:29 ` [LTP] [PATCH 03/31] make: Remove UCLINUX (nommu detection) Petr Vorel
2024-04-11 14:29 ` [LTP] [PATCH 04/31] test.h: Remove MAP_PRIVATE_EXCEPT_UCLINUX Petr Vorel
2024-04-11 14:29 ` [LTP] [PATCH 05/31] tree: Remove FORK_OR_VFORK and tst_vfork() Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 06/31] lib/parse_opts.c: Remove UCLINUX Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 07/31] tlibio.c: " Petr Vorel
2024-04-11 14:59   ` Cyril Hrubis
2024-04-11 20:46     ` Petr Vorel
2024-04-12  7:36       ` Cyril Hrubis
2024-04-12  8:32         ` Andrea Cervesato via ltp
2024-04-12  8:57           ` Cyril Hrubis
2024-04-12  9:08             ` Andrea Cervesato via ltp [this message]
2024-04-11 14:30 ` [LTP] [PATCH 08/31] clone02: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 09/31] connect01: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 10/31] creat06: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 11/31] fcntl: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 12/31] semctl06: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 13/31] kill: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 14/31] madvise02: " Petr Vorel
2024-04-11 15:37   ` Cyril Hrubis
2024-04-11 20:51     ` Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 15/31] mlockall: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 16/31] munmap: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 17/31] writev05: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 18/31] pipe: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 19/31] pause: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 20/31] recv*: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 21/31] send*: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 22/31] sock*: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 23/31] read02: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 24/31] setgroups04: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 25/31] setsid01: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 26/31] sigrelse01: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 27/31] sysinfo02: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 28/31] ustat02: " Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 29/31] lib: Remove -C option and self_exec.c Petr Vorel
2024-04-11 16:02   ` Cyril Hrubis
2024-04-11 20:56     ` Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 30/31] Remove doc/old/nommu-notes.txt Petr Vorel
2024-04-11 14:30 ` [LTP] [PATCH 31/31] doc: UCLINUX has been removed Petr Vorel
2024-05-03 15:39 ` [LTP] [PATCH 00/31] Remove UCLINUX (nommu support) from LTP legacy C API Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2edd5dee-77c3-45c7-a195-3fa5ff38282a@suse.com \
    --to=ltp@lists.linux.it \
    --cc=andrea.cervesato@suse.com \
    --cc=chrubis@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox