Linux Test Project
 help / color / mirror / Atom feed
From: Martin Doucha <mdoucha@suse.cz>
To: Petr Vorel <pvorel@suse.cz>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v4 1/4] tst_test.sh: runtest.sh: Remove unused code
Date: Wed, 10 Aug 2022 17:03:58 +0200	[thread overview]
Message-ID: <3173fba0-778a-69db-2a35-585cc9625a4e@suse.cz> (raw)
In-Reply-To: <20220808113756.11582-2-pvorel@suse.cz>

Hi,
looks good.

Reviewed-by: Martin Doucha <mdoucha@suse.cz>

On 08. 08. 22 13:37, Petr Vorel wrote:
> This code is in tst_print_colored() (probably forgotten to remove code
> from tst_test.sh in a7f613372 when moved to tst_print_colored during
> development; later copy wrong code in d132084bc into runtest.sh).
> 
> Fixes: a7f613372 ("Colorize test type in the output")
> Fixes: d132084bc ("lib: Add script for running tests")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/newlib_tests/runtest.sh | 3 ---
>  testcases/lib/tst_test.sh   | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/lib/newlib_tests/runtest.sh b/lib/newlib_tests/runtest.sh
> index f136bcb88..e78b556c5 100755
> --- a/lib/newlib_tests/runtest.sh
> +++ b/lib/newlib_tests/runtest.sh
> @@ -48,9 +48,6 @@ runtest_res()
>  	local res="$1"
>  	shift
>  
> -	tst_color_enabled
> -	local color=$?
> -
>  	printf "runtest " >&2
>  	tst_print_colored $res "$res: " >&2
>  	echo "$@" >&2
> diff --git a/testcases/lib/tst_test.sh b/testcases/lib/tst_test.sh
> index a35fa2e7b..356af0106 100644
> --- a/testcases/lib/tst_test.sh
> +++ b/testcases/lib/tst_test.sh
> @@ -112,9 +112,6 @@ tst_res()
>  	local res=$1
>  	shift
>  
> -	tst_color_enabled
> -	local color=$?
> -
>  	_tst_inc_res "$res"
>  
>  	printf "$TST_ID $TST_COUNT " >&2


-- 
Martin Doucha   mdoucha@suse.cz
QA Engineer for Software Maintenance
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2022-08-10 15:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 11:37 [LTP] [PATCH v4 0/4] set -e and bashism fixes Petr Vorel
2022-08-08 11:37 ` [LTP] [PATCH v4 1/4] tst_test.sh: runtest.sh: Remove unused code Petr Vorel
2022-08-09  9:25   ` Li Wang
2022-08-10 15:03   ` Martin Doucha [this message]
2022-08-08 11:37 ` [LTP] [PATCH v4 2/4] tst_ansi_color.sh: Allow to run with set -e Petr Vorel
2022-08-09  9:31   ` Li Wang
2022-08-09 12:04     ` Petr Vorel
2022-08-10  2:46       ` Li Wang
2022-08-10  6:36         ` Petr Vorel
2022-08-08 11:37 ` [LTP] [PATCH v4 3/4] tst_test.sh: Fix _tst_cleanup_timer() on " Petr Vorel
2022-08-09  9:35   ` Li Wang
2022-08-09 12:13     ` Petr Vorel
2022-08-10 15:08   ` Martin Doucha
2022-08-10 16:29     ` Petr Vorel
2022-08-11  8:00       ` Martin Doucha
2022-08-11  8:08         ` Petr Vorel
2022-08-11  8:35         ` Petr Vorel
2022-08-08 11:37 ` [LTP] [PATCH v4 4/4] generate_lvm_runfile.sh: Fix bashism Petr Vorel
2022-08-09 10:33   ` Li Wang
2022-08-10 15:13   ` Martin Doucha
2022-08-10 16:38     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3173fba0-778a-69db-2a35-585cc9625a4e@suse.cz \
    --to=mdoucha@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=pvorel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox