public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Avinesh Kumar <akumar@suse.de>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/2] sbrk01: Refactor the test using new LTP API
Date: Wed, 09 Aug 2023 18:52:02 +0530	[thread overview]
Message-ID: <3275791.FnOadfsyHW@localhost> (raw)
In-Reply-To: <CAEemH2dWNJjtbsWn7mf8aghjzMjuWq+XqZWUHw0nx0Vu-Uf7qA@mail.gmail.com>

Hi Li,


> > -       tret = sbrk(test->increment);
> > -       TEST_ERRNO = errno;
> > +       tret = sbrk(tc->increment);
> > +       TST_ERR = errno;
> 
> Can we make use of the LTP test macro TESTPTR()?
> It has already given TST_RET_PRT and TST_ERR inside that.
> 
> See:
> https://github.com/linux-test-project/ltp/blob/master/include/tst_test_macro
> s.h#L30

Thank you for reviewing and pointing this out, I have sent the updated patches 
with TESTPTR() macro.


--
Regards,
Avinesh



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2023-08-09 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 15:35 [LTP] [PATCH 1/2] sbrk01: Refactor the test using new LTP API Avinesh Kumar
2023-08-08 15:35 ` [LTP] [PATCH 2/2] sbrk02.c: " Avinesh Kumar
2023-08-09 10:16 ` [LTP] [PATCH 1/2] sbrk01: " Li Wang
2023-08-09 13:22   ` Avinesh Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3275791.FnOadfsyHW@localhost \
    --to=akumar@suse.de \
    --cc=liwang@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox