From: Marius Kittler <mkittler@suse.de>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v9 4/4] Extend ioctl02 to test termio and termios
Date: Thu, 02 Nov 2023 16:26:39 +0100 [thread overview]
Message-ID: <3276161.44csPzL39Z@linux-9lzf> (raw)
In-Reply-To: <ZUOjeXGrVZizSLBi@yuki>
Am Donnerstag, 2. November 2023, 14:26:17 CET schrieb Cyril Hrubis:
> And that what macros are for, avoiding repetitive parameters, my
> soulution would be to add a macro that just prepares the parameters
> for the function and then keep all the code in a function, i.e.
>
> #define CMP_ATTR(term_exp, term, attr) \
> cmp_attr((term_exp)->attr, (term)->attr, #attr)
That makes sense and turned out to be a very good suggestion, indeed. I
implemented this change and could even apply it to the other macro (after a
bit of simplification). I pushed this change as a new patch set because the
preceding patches of this one have already been merged.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-11-02 15:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 11:47 [LTP] [PATCH v9 0/4] Improve ioctl02.c Marius Kittler
2023-10-26 11:47 ` [LTP] [PATCH v9 1/4] Refactor ioctl02.c to use the new test API Marius Kittler
2023-10-26 13:31 ` Petr Vorel
2023-10-26 11:47 ` [LTP] [PATCH v9 2/4] Make checks for termio flags more strict Marius Kittler
2023-10-26 13:32 ` Petr Vorel
2023-10-26 11:47 ` [LTP] [PATCH v9 3/4] Remove disabled code in ioctl02.c Marius Kittler
2023-10-26 13:32 ` Petr Vorel
[not found] ` <ZTvPszXRVkkh4vcL@yuki>
2023-10-30 11:21 ` Petr Vorel
2023-10-26 11:47 ` [LTP] [PATCH v9 4/4] Extend ioctl02 to test termio and termios Marius Kittler
[not found] ` <ZTvQMpx-q4LnBJgN@yuki>
2023-11-02 13:15 ` Marius Kittler
2023-11-02 13:26 ` Cyril Hrubis
2023-11-02 15:26 ` Marius Kittler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3276161.44csPzL39Z@linux-9lzf \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox