Re: [LTP] [PATCH 2/3] swapon03: Try to swapon() as many files until it fails

[Avinesh Kumar <akumar@suse.de>]

> > > +
> > > +	if (expected_swapfiles < 0) {
> > do we want to proceed when expected_swapfiles is 0 here?
> 
> Yes, because NUM_SWAP_FILES is 15, which is safe for the changes.
> I.e. on my Tumbleweed VM it can be 23 swaps. One is used as filesystem
> partition, therefore it would work on even 22.
Understood, thanks!


> > > -			/* turn on the swap file */
> > > -			TST_EXP_PASS_SILENT(swapon(filename, 0));
> > > +			/* Quit on a first swap file over max */
> > > +			if (swapon(filename, 0) == -1)
> > so now first swapon() fail is here and then we check for errno==EPERM by
> > making another swapon() call in verify_swapon function.
> > Is it possible to combine setup_swap() and verify_swapon() and check for
> > EPERM on first swapon() fail itself?
> 
> I was thinking about it as well. To support -i, we still need to have setup run
> only once. Moving code from setup to test function would require to run "setup"
> part only once (guard with static variable).
> 
> Other option would be to keep setup, but test errno also here (i.e. test it twice).
> I'm not sure which one is less awkward.
ok, I forgot about more iterations scenario.

Reviewed-by: Avinesh Kumar <akumar@suse.de>
(for all patches in the series)

Regards,
Avinesh





-- 
Mailing list info: https://lists.linux.it/listinfo/ltp