* [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info @ 2012-09-06 9:50 Kang Kai 2012-09-06 9:50 ` [LTP] [PATCH] " Kang Kai 2012-09-10 1:58 ` [LTP] [PATCH] V3: " Kang Kai 0 siblings, 2 replies; 5+ messages in thread From: Kang Kai @ 2012-09-06 9:50 UTC (permalink / raw) To: jstancek; +Cc: ltp-list Hi, V3 simplify the cleanup work. V2 just remove the var buf[], and write fname[] to the tmp file. And more cleanup work when test fails. ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* [LTP] [PATCH] mq_open/16-1: use tmp file to share info 2012-09-06 9:50 [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info Kang Kai @ 2012-09-06 9:50 ` Kang Kai 2012-09-13 1:20 ` Wanlong Gao 2012-09-10 1:58 ` [LTP] [PATCH] V3: " Kang Kai 1 sibling, 1 reply; 5+ messages in thread From: Kang Kai @ 2012-09-06 9:50 UTC (permalink / raw) To: jstancek; +Cc: ltp-list In this test case, it uses a variable to share data between child and parent processes. But after fork there is a copy of the variable in child process and modify it will not affect the variable in the parent process. Then when the child process call mq_open() before parent process, the case will fail. Use tmp file to replace the variable. Any modification in child process can be seen in parent process. Signed-off-by: Kang Kai <kai.kang@windriver.com> --- .../conformance/interfaces/mq_open/16-1.c | 36 ++++++++++++++++++- 1 files changed, 34 insertions(+), 2 deletions(-) diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c index e07ce86..9aae29b 100644 --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_open/16-1.c @@ -20,9 +20,11 @@ * this is fine (will have some false positives, but no false negatives). */ +#include <sys/mman.h> #include <sys/stat.h> #include <sys/types.h> #include <sys/wait.h> +#include <errno.h> #include <fcntl.h> #include <mqueue.h> #include <signal.h> @@ -32,11 +34,15 @@ #include "posixtest.h" #define NAMESIZE 50 +#define TNAME "mq_open/16-1.c" int main() { char qname[NAMESIZE]; + char fname[NAMESIZE]; int pid, succeeded = 0; + int fd; + void *pa = NULL; mqd_t childqueue, queue; /* @@ -47,6 +53,26 @@ int main() sprintf(qname, "/mq_open_16-1_%d", getpid()); + sprintf(fname, "/tmp/pts_mq_open_16_1_%d", getpid()); + unlink(fname); + fd = open(fname, O_CREAT | O_RDWR | O_EXCL, + S_IRUSR | S_IWUSR); + if (fd == -1) { + printf(TNAME " Error at open(): %s\n", strerror(errno)); + exit(PTS_UNRESOLVED); + } + /* file is empty now, will cause "Bus error" */ + write(fd, fname, sizeof(int)); + unlink(fname); + + pa = mmap(NULL, sizeof(int), PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); + if (pa == MAP_FAILED) { + printf(TNAME " Error at mmap: %s\n", strerror(errno)); + close(fd); + exit(PTS_FAIL); + } + *(int *)pa = 0; + pid = fork(); if (pid == 0) { sigset_t mask; @@ -63,7 +89,7 @@ int main() childqueue = mq_open(qname, O_CREAT | O_EXCL | O_RDWR, S_IRUSR | S_IWUSR, NULL); if (childqueue != (mqd_t) -1) { - succeeded++; + ++*(int *)pa; #ifdef DEBUG printf("mq_open() in child succeeded\n"); } else { @@ -80,7 +106,7 @@ int main() queue = mq_open(qname, O_CREAT | O_EXCL | O_RDWR, S_IRUSR | S_IWUSR, NULL); if (queue != (mqd_t) -1) { - succeeded++; + ++*(int *)pa; #ifdef DEBUG printf("mq_open() in parent succeeded\n"); } else { @@ -94,6 +120,8 @@ int main() mq_close(queue); mq_close(childqueue); mq_unlink(qname); + close(fd); + munmap(pa, sizeof(int)); return PTS_UNRESOLVED; } @@ -101,6 +129,10 @@ int main() mq_close(childqueue); mq_unlink(qname); + succeeded = *(int *)pa; + close(fd); + munmap(pa, sizeof(int)); + if (succeeded == 0) { printf("Test FAILED - mq_open() never succeeded\n"); return PTS_FAIL; -- 1.7.5.4 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] mq_open/16-1: use tmp file to share info 2012-09-06 9:50 ` [LTP] [PATCH] " Kang Kai @ 2012-09-13 1:20 ` Wanlong Gao 0 siblings, 0 replies; 5+ messages in thread From: Wanlong Gao @ 2012-09-13 1:20 UTC (permalink / raw) To: Kang Kai; +Cc: ltp-list On 09/06/2012 05:50 PM, Kang Kai wrote: > In this test case, it uses a variable to share data between child and > parent processes. But after fork there is a copy of the variable in > child process and modify it will not affect the variable in the parent > process. Then when the child process call mq_open() before parent > process, the case will fail. > > Use tmp file to replace the variable. Any modification in child process > can be seen in parent process. > > Signed-off-by: Kang Kai <kai.kang@windriver.com> Pushed, thank you . Wanlong Gao ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info 2012-09-06 9:50 [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info Kang Kai 2012-09-06 9:50 ` [LTP] [PATCH] " Kang Kai @ 2012-09-10 1:58 ` Kang Kai 2012-09-10 7:15 ` Jan Stancek 1 sibling, 1 reply; 5+ messages in thread From: Kang Kai @ 2012-09-10 1:58 UTC (permalink / raw) To: Kang Kai; +Cc: ltp-list On 2012年09月06日 17:50, Kang Kai wrote: > Hi, Hi Jan, > > V3 simplify the cleanup work. How about this version? Thanks, Kai > > V2 just remove the var buf[], and write fname[] to the tmp file. > And more cleanup work when test fails. > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info 2012-09-10 1:58 ` [LTP] [PATCH] V3: " Kang Kai @ 2012-09-10 7:15 ` Jan Stancek 0 siblings, 0 replies; 5+ messages in thread From: Jan Stancek @ 2012-09-10 7:15 UTC (permalink / raw) To: Kang Kai; +Cc: ltp-list ----- Original Message ----- > From: "Kang Kai" <Kai.Kang@windriver.com> > To: "Kang Kai" <kai.kang@windriver.com> > Cc: jstancek@redhat.com, ltp-list@lists.sourceforge.net > Sent: Monday, 10 September, 2012 3:58:34 AM > Subject: Re: [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info > > On 2012年09月06日 17:50, Kang Kai wrote: > > Hi, > > Hi Jan, > > > > > V3 simplify the cleanup work. > How about this version? Looks OK to me. About child process: I briefly looked at posix spec, but didn't find anything concrete. I'm quite sure fork() on linux doesn't work that way, you'd need CLONE_FILES and CLONE_VM. Regards, Jan > > Thanks, > Kai > > > > > V2 just remove the var buf[], and write fname[] to the tmp file. > > And more cleanup work when test fails. > > > > > > ------------------------------------------------------------------------------ > > Live Security Virtual Conference > > Exclusive live event will cover all the ways today's security and > > threat landscape has changed and how IT managers can respond. > > Discussions > > will include endpoint security, mobile security and the latest in > > malware > > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > > _______________________________________________ > > Ltp-list mailing list > > Ltp-list@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/ltp-list > > > > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-13 1:20 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-06 9:50 [LTP] [PATCH] V3: mq_open/16-1: use tmp file to share info Kang Kai 2012-09-06 9:50 ` [LTP] [PATCH] " Kang Kai 2012-09-13 1:20 ` Wanlong Gao 2012-09-10 1:58 ` [LTP] [PATCH] V3: " Kang Kai 2012-09-10 7:15 ` Jan Stancek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox