Re: [LTP] [RFC PATCH 0/1] brk: use direct syscalls

[Teo Couprie Diaz <teo.coupriediaz@arm.com>]

Hi,

On 30/11/2022 13:15, Cyril Hrubis wrote:
> Hi!
>>>> WDYT about .test_variants? In that case it'd be tested also on musl
>>>> or any platform where it's implemented.
>>> I would got for it, that way we would test both the kernel implemntation
>>> and that libc does something sensible, e.g. returns error.
>>>
>> I'm still quite new to LTP, so I might be understanding things wrong.
>>
>> My understanding of your conversation is that you're suggesting using
>> the .test_variants to have one version of the tests going through the
>> libc wrappers as usual, eventually skipping the test with TCONF if the
>> libc wrapper does not implement the syscall, and one version which would
>> be the the direct syscall I am suggesting in this patch.
>>
>> Would that be correct ? If so it does make sense to me, I could try
>> implementing that.
> Yes, exactly this.

Great, thanks : I will implement this and send a revision when it's done !

Best regards,
Téo


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp