From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [RFC] [PATCH] safe_macros: Add fallback pwrite() and pread() declarations
Date: Thu, 12 Jan 2017 04:07:09 -0500 (EST) [thread overview]
Message-ID: <365395850.1733202.1484212029508.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20170112090232.GA16875@rei.lan>
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Thursday, 12 January, 2017 10:02:32 AM
> Subject: Re: [LTP] [RFC] [PATCH] safe_macros: Add fallback pwrite() and pread() declarations
>
> Hi!
> > > I was thinking about this, and I think that we should rather go with a
> > > safer approach, i.e. moving the safe_pread/safe_pwrite into a separate
> > > header. Something as the following patch.
> >
> > +1 for safer approach, I didn't know about glibc macros.
> > Does this affect oldlib too?
>
> Not anymore, there was one user with zero offset which was converted to
> plain old SAFE_WRITE() and these two safe macros were then removed from
> oldlib safe macros in f4b028122.
Ah, I see. No objections to patch from my side.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
next prev parent reply other threads:[~2017-01-12 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 15:47 [LTP] [RFC] [PATCH] safe_macros: Add fallback pwrite() and pread() declarations Cyril Hrubis
2017-01-11 14:41 ` Cyril Hrubis
2017-01-12 8:33 ` Jan Stancek
2017-01-12 9:02 ` Cyril Hrubis
2017-01-12 9:07 ` Jan Stancek [this message]
2017-01-12 9:10 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365395850.1733202.1484212029508.JavaMail.zimbra@redhat.com \
--to=jstancek@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox