Re: [LTP] [PATCH] truncate03: impose max file size limit for EFBIG test

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> From: "Shuang Qiu" <shuang.qiu@oracle.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "Jan Stancek" <jstancek@redhat.com>
> Sent: Wednesday, 14 January, 2015 10:15:20 AM
> Subject: Re: [LTP] [PATCH] truncate03: impose max file size limit for EFBIG test
> 
> Hello,
> I find that EFBIG test will fail over nfs filesystem because
> unexpectedly succeed too.
> It can catch SIGXFSZ signal but will not fail with EFBIG after blocked
> SIGXFSZ.
> I'm not sure if it is expected behavior for truncate against nfs filesystem.
> Could anyone help to check?

I'm guessing a bug. write(2) on nfs respects RLIMIT_FSIZE, but truncate(2) does not.
I think best would be to check with some nfs people: linux-nfs@vger.kernel.org

Regards,
Jan

> 
> Thanks
> Shuang
> On 08/20/2014 05:42 PM, Jan Stancek wrote:
> > Using LLONG_MAX as maximum can fail on XFS, because here the maximum
> > file size is 2^63-1, so this test may unexpectedly succeed.
> >
> > Impose limit via setrlimit(RLIMIT_FSIZE,..) and set value used
> > in EFBIG test to be twice that much.
> >
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
> > ---
> >   testcases/kernel/syscalls/truncate/truncate03.c |   18 +++++++++++++++++-
> >   1 files changed, 17 insertions(+), 1 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/truncate/truncate03.c
> > b/testcases/kernel/syscalls/truncate/truncate03.c
> > index ed5073d..54b7d3c 100644
> > --- a/testcases/kernel/syscalls/truncate/truncate03.c
> > +++ b/testcases/kernel/syscalls/truncate/truncate03.c
> > @@ -50,6 +50,7 @@
> >   #include <string.h>
> >   #include <signal.h>
> >   #include <pwd.h>
> > +#include <sys/resource.h>
> >   
> >   #include "test.h"
> >   #include "usctest.h"
> > @@ -65,6 +66,7 @@
> >   #define NEW_MODE	S_IRUSR | S_IRGRP | S_IROTH
> >   #define DIR_MODE	S_IRWXU
> >   #define TRUNC_LEN	256
> > +#define MAX_FSIZE	(16*1024*1024)
> >   
> >   static char long_pathname[PATH_MAX + 2];
> >   
> > @@ -82,7 +84,7 @@ static struct test_case_t {
> >   	{ long_pathname, TRUNC_LEN, ENAMETOOLONG },
> >   	{ "", TRUNC_LEN, ENOENT },
> >   	{ TEST_DIR1, TRUNC_LEN, EISDIR },
> > -	{ TEST_FILE3, LLONG_MAX, EFBIG },
> > +	{ TEST_FILE3, MAX_FSIZE*2, EFBIG },
> >   	{ TEST_SYM1, TRUNC_LEN, ELOOP }
> >   };
> >   
> > @@ -124,6 +126,8 @@ void setup(void)
> >   {
> >   	struct passwd *ltpuser;
> >   	char *bad_addr;
> > +	struct rlimit rlim;
> > +	sigset_t sigset;
> >   
> >   	tst_sig(NOFORK, DEF_HANDLER, cleanup);
> >   
> > @@ -156,6 +160,18 @@ void setup(void)
> >   
> >   	SAFE_SYMLINK(cleanup, TEST_SYM1, TEST_SYM2);
> >   	SAFE_SYMLINK(cleanup, TEST_SYM2, TEST_SYM1);
> > +
> > +	rlim.rlim_cur = MAX_FSIZE;
> > +	rlim.rlim_max = MAX_FSIZE;
> > +	TEST(setrlimit(RLIMIT_FSIZE, &rlim));
> > +	if (TEST_RETURN != 0)
> > +		tst_brkm(TBROK | TTERRNO, cleanup, "setrlimit");
> > +
> > +	sigemptyset(&sigset);
> > +	sigaddset(&sigset, SIGXFSZ);
> > +	TEST(sigprocmask(SIG_BLOCK, &sigset, NULL));
> > +	if (TEST_RETURN != 0)
> > +		tst_brkm(TBROK | TTERRNO, cleanup, "sigprocmask");
> >   }
> >   
> >   void truncate_verify(struct test_case_t *tc)
> 
> 

------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list