[LTP] [PATCH] lib/tst_test.c: Bugfix for heartbeat

Cyril Hrubis
2021-04-13T09:37:06Z

Hi!
> According to your review, is there any problems in the patch as follows:
>
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 45753d1ca..0a096d666 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -1156,7 +1156,16 @@ static void heartbeat(void)
> if (tst_clock_gettime(CLOCK_MONOTONIC, &tst_start_time))
> tst_res(TWARN | TERRNO, "tst_clock_gettime() failed");
>
> - kill(getppid(), SIGUSR1);
> + if (getppid() == 1) {
> + tst_res(TFAIL, "Main test process might have exit!");
> + /*
> + * We need kill the task group immediately since the
> + * main process has exit.
> + */
> + kill(0, SIGKILL);
> + exit(-1);

Not that it matters that much, but I would do exit(TBROK);

> + } else
> + kill(getppid(), SIGUSR1);

No need for the else branch here now that we do exit() a the end of the
if () block.

Other than that it looks good.

--
Cyril Hrubis
chrubis@suse.cz