* [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
@ 2014-12-04 8:34 Han Pingtian
2014-12-04 10:17 ` Cyril Hrubis
0 siblings, 1 reply; 8+ messages in thread
From: Han Pingtian @ 2014-12-04 8:34 UTC (permalink / raw)
To: ltp-list
Hi,
On our systems, root belongs to only one group. getgroups01 has this
result:
getgroups01 1 TPASS : getgroups failed as expected with EINVAL
getgroups01 2 TPASS : getgroups did not modify the gidset array
getgroups01 3 TCONF : getgroups01.c:129: getgroups returned 1; unable to test that using ngrps >=1 but less than number of grps
getgroups01 4 TPASS : getgroups(NGROUPS,gidset) returned 1 contains gid 0 (from getgid)
Looks like we can set supplementary groups by setgroups() in setup(),
then 3# will succeed if running as privileged user. If we call
setgroups(), then initgroups() can be left out. With this patch, when
running as root:
getgroups01 1 TPASS : getgroups failed as expected with EINVAL
getgroups01 2 TPASS : getgroups did not modify the gidset array
getgroups01 3 TPASS : getgroups failed as expected with EINVAL
getgroups01 4 TPASS : getgroups(NGROUPS,gidset) returned 3 contains gid 0 (from getgid)
running as unprivileged user:
getgroups01 1 TPASS : getgroups failed as expected with EINVAL
getgroups01 2 TPASS : getgroups did not modify the gidset array
getgroups01 3 TCONF : getgroups01.c:127: getgroups returned 1; unable to test that using ngrps >=1 but less than number of grps
getgroups01 4 TPASS : getgroups(NGROUPS,gidset) returned 1 contains gid 1001 (from getgid)
From caf7b59519b0f9323805aae9d6a607a30ea3ba4e Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Thu, 4 Dec 2014 16:07:25 +0800
Subject: [PATCH] set supplementary groups instead of relying on system setting
On a system where root belongs to only one group, the 3# test of
getgroups01 will fail by TCONF. But if we call setgroups() to set
supplementary groups, the test can succeed if run as privileged user.
With this patch, it'll still fail by TCONF when being run by
unprivileged user.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
index 9fb4c98..28559d3 100644
--- a/testcases/kernel/syscalls/getgroups/getgroups01.c
+++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
@@ -74,8 +74,6 @@ int main(int ac, char **av)
int i;
int entries;
- initgroups("root", 0);
-
if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
@@ -183,6 +181,9 @@ static void setup(void)
tst_sig(FORK, DEF_HANDLER, cleanup);
TEST_PAUSE;
+
+ GID_T init_gidset[3] = {0, 1, 2};
+ setgroups(3, init_gidset);
}
static void cleanup(void)
--
1.9.3
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-04 8:34 [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF Han Pingtian
@ 2014-12-04 10:17 ` Cyril Hrubis
2014-12-04 10:44 ` Jan Stancek
2014-12-05 1:45 ` [LTP] [PATCH v2] " Han Pingtian
0 siblings, 2 replies; 8+ messages in thread
From: Cyril Hrubis @ 2014-12-04 10:17 UTC (permalink / raw)
To: ltp-list
Hi!
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
> testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
> index 9fb4c98..28559d3 100644
> --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> @@ -74,8 +74,6 @@ int main(int ac, char **av)
> int i;
> int entries;
>
> - initgroups("root", 0);
> -
> if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
>
> @@ -183,6 +181,9 @@ static void setup(void)
> tst_sig(FORK, DEF_HANDLER, cleanup);
>
> TEST_PAUSE;
> +
> + GID_T init_gidset[3] = {0, 1, 2};
This should be gid_t instead of GID_T. The uppercase prototypes are for
raw syscalls only. The setgroups() you call is glibc wrapper instead.
> + setgroups(3, init_gidset);
Otherwise it looks good to me.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-04 10:17 ` Cyril Hrubis
@ 2014-12-04 10:44 ` Jan Stancek
2014-12-05 1:37 ` Han Pingtian
2014-12-05 1:45 ` [LTP] [PATCH v2] " Han Pingtian
1 sibling, 1 reply; 8+ messages in thread
From: Jan Stancek @ 2014-12-04 10:44 UTC (permalink / raw)
To: ltp-list
----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: ltp-list@lists.sourceforge.net
> Sent: Thursday, 4 December, 2014 11:17:41 AM
> Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
>
> Hi!
> > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > ---
> > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > index 9fb4c98..28559d3 100644
> > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > int i;
> > int entries;
> >
> > - initgroups("root", 0);
> > -
> > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> >
> > @@ -183,6 +181,9 @@ static void setup(void)
I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID.
> > tst_sig(FORK, DEF_HANDLER, cleanup);
> >
> > TEST_PAUSE;
> > +
> > + GID_T init_gidset[3] = {0, 1, 2};
>
> This should be gid_t instead of GID_T. The uppercase prototypes are for
> raw syscalls only. The setgroups() you call is glibc wrapper instead.
>
> > + setgroups(3, init_gidset);
>
> Otherwise it looks good to me.
To me as well.
Regards,
Jan
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-04 10:44 ` Jan Stancek
@ 2014-12-05 1:37 ` Han Pingtian
2014-12-05 7:50 ` Jan Stancek
0 siblings, 1 reply; 8+ messages in thread
From: Han Pingtian @ 2014-12-05 1:37 UTC (permalink / raw)
To: ltp-list
On Thu, Dec 04, 2014 at 05:44:14AM -0500, Jan Stancek wrote:
> ----- Original Message -----
> > From: "Cyril Hrubis" <chrubis@suse.cz>
> > To: ltp-list@lists.sourceforge.net
> > Sent: Thursday, 4 December, 2014 11:17:41 AM
> > Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
> >
> > Hi!
> > > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > > ---
> > > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > index 9fb4c98..28559d3 100644
> > > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > > int i;
> > > int entries;
> > >
> > > - initgroups("root", 0);
> > > -
> > > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> > >
> > > @@ -183,6 +181,9 @@ static void setup(void)
>
> I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID.
I think getgroups() doesn't need privileged power, so we shouldn't limit
this case with tst_require_root, because this case is testing
getgroups(). With this patch applied, if run by unprivileged user, 3#
will fail by TCONF, but other tests will pass.
Thanks.
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH v2] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-04 10:17 ` Cyril Hrubis
2014-12-04 10:44 ` Jan Stancek
@ 2014-12-05 1:45 ` Han Pingtian
2014-12-05 5:37 ` [LTP] [PATCH v3] " Han Pingtian
1 sibling, 1 reply; 8+ messages in thread
From: Han Pingtian @ 2014-12-05 1:45 UTC (permalink / raw)
To: ltp-list
On Thu, Dec 04, 2014 at 11:17:41AM +0100, Cyril Hrubis wrote:
> Hi!
> > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > ---
> > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > index 9fb4c98..28559d3 100644
> > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > int i;
> > int entries;
> >
> > - initgroups("root", 0);
> > -
> > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> >
> > @@ -183,6 +181,9 @@ static void setup(void)
> > tst_sig(FORK, DEF_HANDLER, cleanup);
> >
> > TEST_PAUSE;
> > +
> > + GID_T init_gidset[3] = {0, 1, 2};
>
> This should be gid_t instead of GID_T. The uppercase prototypes are for
> raw syscalls only. The setgroups() you call is glibc wrapper instead.
>
> > + setgroups(3, init_gidset);
>
> Otherwise it looks good to me.
Thanks, this is the new patch for review.
From 261b475fe4ecf8572003b0c444394b67feb0c781 Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Thu, 4 Dec 2014 16:07:25 +0800
Subject: [PATCH] set supplementary groups instead of relying on system setting
On a system where root belongs to only one group, the 3# test of
getgroups01 will fail by TCONF. But if we call setgroups() to set
supplementary groups, the test can succeed if run as privileged user.
With this patch, it'll still fail by TCONF when being run by
unprivileged user.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
index 9fb4c98..02c8ce0 100644
--- a/testcases/kernel/syscalls/getgroups/getgroups01.c
+++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
@@ -74,8 +74,6 @@ int main(int ac, char **av)
int i;
int entries;
- initgroups("root", 0);
-
if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
@@ -183,6 +181,9 @@ static void setup(void)
tst_sig(FORK, DEF_HANDLER, cleanup);
TEST_PAUSE;
+
+ git_t init_gidset[3] = {0, 1, 2};
+ setgroups(3, init_gidset);
}
static void cleanup(void)
--
1.9.3
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH v3] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-05 1:45 ` [LTP] [PATCH v2] " Han Pingtian
@ 2014-12-05 5:37 ` Han Pingtian
2014-12-08 12:55 ` Cyril Hrubis
0 siblings, 1 reply; 8+ messages in thread
From: Han Pingtian @ 2014-12-05 5:37 UTC (permalink / raw)
To: ltp-list
On Fri, Dec 05, 2014 at 09:45:13AM +0800, Han Pingtian wrote:
> On Thu, Dec 04, 2014 at 11:17:41AM +0100, Cyril Hrubis wrote:
> > Hi!
> > > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > > ---
> > > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > index 9fb4c98..28559d3 100644
> > > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > > int i;
> > > int entries;
> > >
> > > - initgroups("root", 0);
> > > -
> > > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> > >
> > > @@ -183,6 +181,9 @@ static void setup(void)
> > > tst_sig(FORK, DEF_HANDLER, cleanup);
> > >
> > > TEST_PAUSE;
> > > +
> > > + GID_T init_gidset[3] = {0, 1, 2};
> >
> > This should be gid_t instead of GID_T. The uppercase prototypes are for
> > raw syscalls only. The setgroups() you call is glibc wrapper instead.
> >
> > > + setgroups(3, init_gidset);
> >
> > Otherwise it looks good to me.
>
> Thanks, this is the new patch for review.
I'm sorry that there is a typo in V2. Please have a look at this:
From 1f260f261266ccddf16854c87dd72b4cf91bd745 Mon Sep 17 00:00:00 2001
From: Han Pingtian <hanpt@linux.vnet.ibm.com>
Date: Thu, 4 Dec 2014 16:07:25 +0800
Subject: [PATCH] set supplementary groups instead of relying on system setting
On a system where root belongs to only one group, the 3# test of
getgroups01 will fail by TCONF. But if we call setgroups() to set
supplementary groups, the test can succeed if run as privileged user.
With this patch, it'll still fail by TCONF when being run by
unprivileged user.
Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
---
testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c b/testcases/kernel/syscalls/getgroups/getgroups01.c
index 9fb4c98..2c1407b 100644
--- a/testcases/kernel/syscalls/getgroups/getgroups01.c
+++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
@@ -74,8 +74,6 @@ int main(int ac, char **av)
int i;
int entries;
- initgroups("root", 0);
-
if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
@@ -183,6 +181,9 @@ static void setup(void)
tst_sig(FORK, DEF_HANDLER, cleanup);
TEST_PAUSE;
+
+ gid_t init_gidset[3] = {0, 1, 2};
+ setgroups(3, init_gidset);
}
static void cleanup(void)
--
1.9.3
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-05 1:37 ` Han Pingtian
@ 2014-12-05 7:50 ` Jan Stancek
0 siblings, 0 replies; 8+ messages in thread
From: Jan Stancek @ 2014-12-05 7:50 UTC (permalink / raw)
To: Han Pingtian; +Cc: ltp-list
----- Original Message -----
> From: "Han Pingtian" <hanpt@linux.vnet.ibm.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Friday, 5 December, 2014 2:37:22 AM
> Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
>
> On Thu, Dec 04, 2014 at 05:44:14AM -0500, Jan Stancek wrote:
> > ----- Original Message -----
> > > From: "Cyril Hrubis" <chrubis@suse.cz>
> > > To: ltp-list@lists.sourceforge.net
> > > Sent: Thursday, 4 December, 2014 11:17:41 AM
> > > Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set
> > > supplementary groups to prevent TCONF
> > >
> > > Hi!
> > > > Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> > > > ---
> > > > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++--
> > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > > b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > > index 9fb4c98..28559d3 100644
> > > > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c
> > > > @@ -74,8 +74,6 @@ int main(int ac, char **av)
> > > > int i;
> > > > int entries;
> > > >
> > > > - initgroups("root", 0);
> > > > -
> > > > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL)
> > > > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg);
> > > >
> > > > @@ -183,6 +181,9 @@ static void setup(void)
> >
> > I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID.
>
> I think getgroups() doesn't need privileged power, so we shouldn't limit
> this case with tst_require_root, because this case is testing
> getgroups(). With this patch applied, if run by unprivileged user, 3#
> will fail by TCONF, but other tests will pass.
OK, looks like initgroups is implemented via setgroups, so this
was failing silently before as well.
Regards,
Jan
>
> Thanks.
>
>
> ------------------------------------------------------------------------------
> Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
> from Actuate! Instantly Supercharge Your Business Reports and Dashboards
> with Interactivity, Sharing, Native Excel Exports, App Integration & more
> Get technology previously reserved for billion-dollar corporations, FREE
> http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [LTP] [PATCH v3] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF
2014-12-05 5:37 ` [LTP] [PATCH v3] " Han Pingtian
@ 2014-12-08 12:55 ` Cyril Hrubis
0 siblings, 0 replies; 8+ messages in thread
From: Cyril Hrubis @ 2014-12-08 12:55 UTC (permalink / raw)
To: ltp-list
Hi!
Pushed, thanks.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-08 12:55 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 8:34 [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF Han Pingtian
2014-12-04 10:17 ` Cyril Hrubis
2014-12-04 10:44 ` Jan Stancek
2014-12-05 1:37 ` Han Pingtian
2014-12-05 7:50 ` Jan Stancek
2014-12-05 1:45 ` [LTP] [PATCH v2] " Han Pingtian
2014-12-05 5:37 ` [LTP] [PATCH v3] " Han Pingtian
2014-12-08 12:55 ` Cyril Hrubis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox