From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-3.v43.ch3.sourceforge.com ([172.29.43.193] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.76) (envelope-from ) id 1XwTtW-0001XT-Kd for ltp-list@lists.sourceforge.net; Thu, 04 Dec 2014 10:44:22 +0000 Received: from mx6-phx2.redhat.com ([209.132.183.39]) by sog-mx-3.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) id 1XwTtV-00015E-2H for ltp-list@lists.sourceforge.net; Thu, 04 Dec 2014 10:44:22 +0000 Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB4AiEFk026954 for ; Thu, 4 Dec 2014 05:44:14 -0500 Date: Thu, 4 Dec 2014 05:44:14 -0500 (EST) From: Jan Stancek Message-ID: <390870174.13092868.1417689854590.JavaMail.zimbra@redhat.com> In-Reply-To: <20141204101741.GB15326@rei.suse.de> References: <20141204083400.GA2704@localhost.localdomain> <20141204101741.GB15326@rei.suse.de> MIME-Version: 1.0 Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: ltp-list@lists.sourceforge.net ----- Original Message ----- > From: "Cyril Hrubis" > To: ltp-list@lists.sourceforge.net > Sent: Thursday, 4 December, 2014 11:17:41 AM > Subject: Re: [LTP] [PATCH] syscalls/getgroups/getgroups01: set supplementary groups to prevent TCONF > > Hi! > > Signed-off-by: Han Pingtian > > --- > > testcases/kernel/syscalls/getgroups/getgroups01.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/testcases/kernel/syscalls/getgroups/getgroups01.c > > b/testcases/kernel/syscalls/getgroups/getgroups01.c > > index 9fb4c98..28559d3 100644 > > --- a/testcases/kernel/syscalls/getgroups/getgroups01.c > > +++ b/testcases/kernel/syscalls/getgroups/getgroups01.c > > @@ -74,8 +74,6 @@ int main(int ac, char **av) > > int i; > > int entries; > > > > - initgroups("root", 0); > > - > > if ((msg = parse_opts(ac, av, NULL, NULL)) != NULL) > > tst_brkm(TBROK, NULL, "OPTION PARSING ERROR - %s", msg); > > > > @@ -183,6 +181,9 @@ static void setup(void) I'd add tst_require_root() to setup, since setgroups() requires CAP_SETGID. > > tst_sig(FORK, DEF_HANDLER, cleanup); > > > > TEST_PAUSE; > > + > > + GID_T init_gidset[3] = {0, 1, 2}; > > This should be gid_t instead of GID_T. The uppercase prototypes are for > raw syscalls only. The setgroups() you call is glibc wrapper instead. > > > + setgroups(3, init_gidset); > > Otherwise it looks good to me. To me as well. Regards, Jan > > -- > Cyril Hrubis > chrubis@suse.cz > > ------------------------------------------------------------------------------ > Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server > from Actuate! Instantly Supercharge Your Business Reports and Dashboards > with Interactivity, Sharing, Native Excel Exports, App Integration & more > Get technology previously reserved for billion-dollar corporations, FREE > http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list