public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: xieziyao <xieziyao@huawei.com>
To: ltp@lists.linux.it
Subject: [LTP] 答复:  [PATCH] syscalls/chdir01: Add umask before mkdir
Date: Wed, 31 Mar 2021 02:19:42 +0000	[thread overview]
Message-ID: <3bcb94a23de3476ca3c4c6f68fe3b1f6@huawei.com> (raw)
In-Reply-To: <YGNXkZMqqJpviwkL@pevik>

Hi Gongyi, Petr,

Sorry, I didn't subscribe to the mail when Gongyi's patch was submitted.

Anyway, thank you for your discussion of this issue and for merging this patch.

Regards,
Ziyao

-----????-----
???: Petr Vorel [mailto:pvorel@suse.cz] 
????: 2021?3?31? 0:54
???: zhaogongyi <zhaogongyi@huawei.com>
??: xieziyao <xieziyao@huawei.com>; ltp@lists.linux.it
??: Re: [LTP] [PATCH] syscalls/chdir01: Add umask before mkdir

Hi Gongyi,

> Umask is always 022 in many system env. In this testcase, if umask is 
> not 022, for example, umask is 0077, test would fail because the file 
> mode is affected by umask.
Thanks a lot for a giving example. I tested only 0066.

I'm sorry I accepted the Ziyao version as it had better description, reverted back changes and will work on any mode in SAFE_MKDIR(). I put your Reported-by:
tag.

I'll also send one more fix for exfat.

Kind regards,
Petr

      reply	other threads:[~2021-03-31  2:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 13:17 [LTP] [PATCH] syscalls/chdir01: Add umask before mkdir zhaogongyi
2021-03-30 16:53 ` Petr Vorel
2021-03-31  2:19   ` xieziyao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bcb94a23de3476ca3c4c6f68fe3b1f6@huawei.com \
    --to=xieziyao@huawei.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox