From: Joerg Vehlow <lkml@jv-coder.de>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 2/2] shell: Extend timeout tests, to run on multiple shells
Date: Mon, 21 Jun 2021 10:01:07 +0200 [thread overview]
Message-ID: <3fd9fb2f-3242-5268-eef3-0e5aa4faecef@jv-coder.de> (raw)
In-Reply-To: <YNA+6shWiWYRNi2P@pevik>
Hi Petr,
On 6/21/2021 9:25 AM, Petr Vorel wrote:
> Hi all,
>
> I wonder what is the state of this patchset?
> Do we still consider it?
I still think this should be included, but we can drop shells if you like.
> Apart from reducing shells (i.e. which distro has ash, which is not
> alias to other shell in the list) I'm not against non-default shells, but I
> don't like how whole test gets complicated by this.
>
> Also we're reinventing wheel with printing results, checking whether test exist
> etc. Maybe using test API for this?
I know that this is reimplementing a lot of stuff, but I think I tried
using the lib (a bit strange using the object under test to test it, but
would be ok for me), but failed to do so.
I guess this was because it uses traps and the set -m stuff, but I am
not sure anymore.
J?rg
next prev parent reply other threads:[~2021-06-21 8:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 6:31 [LTP] [PATCH 1/2] shell: Fix timeout process termination for zsh Joerg Vehlow
2021-05-19 6:31 ` [LTP] [PATCH 2/2] shell: Extend timeout tests, to run on multiple shells Joerg Vehlow
2021-05-19 10:28 ` Cyril Hrubis
2021-05-19 11:03 ` Joerg Vehlow
2021-05-19 12:57 ` Petr Vorel
2021-06-21 7:25 ` Petr Vorel
2021-06-21 8:01 ` Joerg Vehlow [this message]
2021-06-21 8:19 ` Petr Vorel
2021-05-19 10:18 ` [LTP] [PATCH 1/2] shell: Fix timeout process termination for zsh Li Wang
2021-05-19 10:26 ` Joerg Vehlow
2021-05-19 10:29 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fd9fb2f-3242-5268-eef3-0e5aa4faecef@jv-coder.de \
--to=lkml@jv-coder.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox