public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: Jeffrey Bastian <jbastian@redhat.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] syslog/syslog-lib.sh: support systemd journal
Date: Thu, 9 Jul 2015 12:49:35 -0400 (EDT)	[thread overview]
Message-ID: <438616599.15156602.1436460575320.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20150709163341.GU17625@tarantula.localdomain>





----- Original Message -----
> From: "Jeffrey Bastian" <jbastian@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Thursday, 9 July, 2015 6:33:41 PM
> Subject: Re: [LTP] [PATCH] syslog/syslog-lib.sh: support systemd journal
> 
> On Thu, Jul 09, 2015 at 10:46:42AM -0400, Jan Stancek wrote:
> > Presumably because you are running new systemd. Can you try with
> > "ForwardToSyslog=yes" set in journald.conf (which is the case for old
> > systemd)?
> > 
> > That still gives me duplicated messages with v2 of the patch.
> 
> Ok, I see it now: systemd-208 gets duplicates with v2 of the patch, and
> systemd-219 with ForwardToSyslog=yes also gets duplicates.
> 
> This will complicate the patch a bit.  If I understand it correctly, LTP
> proc01 needs to do something like this:
> 
>   if ForwardToSyslog is enabled OR
>      (systemd version < 216 AND using default journald.conf)
>   then
>       use imuxsock
>   else
>       use imjournal
>   endif
> 

I think it's enough to look at rsyslog.conf to check if imjournal is in use.
If it's in distro rsyslog.conf, we know we can use it too. If not, we fall back
to imuxsock. 

if rsyslog.conf is using imjournal then 
  use imjournal
else
  use imuxsock

Regards,
Jan

> I'll send a new patch soon.
> 
> Thanks,
> Jeff
> 
> ------------------------------------------------------------------------------
> Don't Limit Your Business. Reach for the Cloud.
> GigeNET's Cloud Solutions provide you with the tools and support that
> you need to offload your IT needs and focus on growing your business.
> Configured For All Businesses. Start Your Cloud Today.
> https://www.gigenetcloud.com/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2015-07-09 16:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 19:41 [LTP] [PATCH] syslog/syslog-lib.sh: support systemd journal Jeffrey Bastian
2015-07-09  6:59 ` Jan Stancek
2015-07-09  8:19   ` Jan Stancek
2015-07-09 12:45     ` Jeffrey Bastian
2015-07-09 13:39       ` Jan Stancek
2015-07-09 14:37         ` Jeffrey Bastian
2015-07-09 14:46           ` Jan Stancek
2015-07-09 16:33             ` Jeffrey Bastian
2015-07-09 16:49               ` Jan Stancek [this message]
2015-07-09 22:16                 ` [LTP] [PATCH v3] " Jeffrey Bastian
2015-07-13 11:43                   ` Jan Stancek
2015-07-16  7:01                     ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438616599.15156602.1436460575320.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=jbastian@redhat.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox