Re: [LTP] [PATCH 3/3] timer_settime/5-3: fix test hung

[Jan Stancek <jstancek@redhat.com>]

----- Original Message -----
> From: "Kang Kai" <kai.kang@windriver.com>
> To: ltp-list@lists.sourceforge.net
> Cc: "Zhenfeng Zhao" <Zhenfeng.Zhao@windriver.com>
> Sent: Thursday, 9 August, 2012 12:30:58 PM
> Subject: [LTP] [PATCH 3/3] timer_settime/5-3: fix test hung
> 
> This case hangs on sugarbay(intel x86_64) platform.
> 
> The root cause is that the case calls timer_settime with time which
> already took place and then calls sleep. When the timer expires and
> sends signal the sleep will be break.
> 
> But on sugarbay the timer always expires before the case enters
> sleep,
> then it always sleeps NUMTESTS * LONGSLEEPTIME seconds. So it exceeds
> the time limit set by auto-run test shell script, and reports that it
> hangs.
> 
> Decrease LONGSLEEPTIME value to avoid this issue.
> 
> Signed-off-by: Kang Kai <kai.kang@windriver.com>

Looks good to me, 5 secs is still enough time.

Reviewed-by: Jan Stancek <jstancek@redhat.com>

> ---
>  .../conformance/interfaces/timer_settime/5-3.c     |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/testcases/open_posix_testsuite/conformance/interfaces/timer_settime/5-3.c
> b/testcases/open_posix_testsuite/conformance/interfaces/timer_settime/5-3.c
> index 0ad1957..4a47458 100644
> ---
> a/testcases/open_posix_testsuite/conformance/interfaces/timer_settime/5-3.c
> +++
> b/testcases/open_posix_testsuite/conformance/interfaces/timer_settime/5-3.c
> @@ -27,7 +27,7 @@
>  
>  #define SIGTOTEST SIGALRM
>  
> -#define LONGSLEEPTIME 10
> +#define LONGSLEEPTIME 5
>  
>  #define NUMTESTS 30
>  
> @@ -105,4 +105,4 @@ int main(int argc, char *argv[])
>  
>  	printf("This code should not be executed.\n");
>  	return PTS_UNRESOLVED;
> -}
> \ No newline at end of file
> +}
> --
> 1.7.5.4
> 
> 
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond.
> Discussions
> will include endpoint security, mobile security and the latest in
> malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
> 

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list