[LTP] duplicated runltp options

[LTP] duplicated runltp options

[Cyril Hrubis]

Hi!
Looks like we overided the -T option for runltp in:

commit 5f71cf97d5753c5506cdf8287812f28e2fffe4aa
Author: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
Date:   Tue Sep 23 15:59:43 2014 +0800

    runltp, pan/ltp-pan.c: record test cases(not fully tested) into file


And now the -T is listed twice in the options and in the case.

...
-T TCONFCMDFILE Command file with all test cases that are not fully tested.
...
-T REPETITION   Execute the testsuite for REPETITION no. of times
...

And since nobody reported the problem so far, I guess that -T for
repetition wasn't widely used. So I would like to fix that by renaming
the -T REPETIONT to  -I ITERATIONS. Does that sound reasonably?

-- 
Cyril Hrubis
chrubis@suse.cz

[LTP] duplicated runltp options

[Jan Stancek]

----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: ltp@lists.linux.it
> Sent: Tuesday, 26 April, 2016 1:07:43 PM
> Subject: [LTP] duplicated runltp options
> 
> Hi!
> Looks like we overided the -T option for runltp in:
> 
> commit 5f71cf97d5753c5506cdf8287812f28e2fffe4aa
> Author: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
> Date:   Tue Sep 23 15:59:43 2014 +0800
> 
>     runltp, pan/ltp-pan.c: record test cases(not fully tested) into file
> 
> 
> And now the -T is listed twice in the options and in the case.
> 
> ...
> -T TCONFCMDFILE Command file with all test cases that are not fully tested.
> ...
> -T REPETITION   Execute the testsuite for REPETITION no. of times
> ...
> 
> And since nobody reported the problem so far, I guess that -T for
> repetition wasn't widely used. So I would like to fix that by renaming
> the -T REPETIONT to  -I ITERATIONS. Does that sound reasonably?

It does to me, code seems to call it as "iteration" already:
  echo "Test Tags will be Prepended with ITERATION NO.s....."

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 
> --
> Mailing list info: https://lists.linux.it/listinfo/ltp
> 

[LTP] duplicated runltp options

[Cyril Hrubis]

Hi!
> > And since nobody reported the problem so far, I guess that -T for
> > repetition wasn't widely used. So I would like to fix that by renaming
> > the -T REPETIONT to  -I ITERATIONS. Does that sound reasonably?
> 
> It does to me, code seems to call it as "iteration" already:
>   echo "Test Tags will be Prepended with ITERATION NO.s....."

Fix pushed.

-- 
Cyril Hrubis
chrubis@suse.cz