* Re: [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh
2014-10-10 8:06 ` [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh Xu Wang
@ 2014-10-14 7:51 ` Eryu Guan
2014-10-14 12:57 ` Jan Stancek
1 sibling, 0 replies; 3+ messages in thread
From: Eryu Guan @ 2014-10-14 7:51 UTC (permalink / raw)
To: Xu Wang; +Cc: ltp-list
On Fri, Oct 10, 2014 at 04:06:48AM -0400, Xu Wang wrote:
> From fbc38181f0504d5e92def922977da2dd0ae0ee8b Mon Sep 17 00:00:00 2001
> From: George Wang <xuw@redhat.com>
> Date: Fri, 10 Oct 2014 15:59:16 +0800
> Subject: [PATCH] fs: Fix the check bug in
> testcases/kernel/fs/acl/tacl_xattr.sh
Can you please describe what bug you're trying to fix in commit log?
And you can use git send-email to send patch, as you did to the other
patch :)
Thanks,
Eryu
>
> Signed-off-by: George Wang <xuw@redhat.com>
> ---
> testcases/kernel/fs/acl/tacl_xattr.sh | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/testcases/kernel/fs/acl/tacl_xattr.sh b/testcases/kernel/fs/acl/tacl_xattr.sh
> index 99f6a95..5a60a04 100755
> --- a/testcases/kernel/fs/acl/tacl_xattr.sh
> +++ b/testcases/kernel/fs/acl/tacl_xattr.sh
> @@ -247,24 +247,24 @@ su - tacluser1 << TACL_USER1
> if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
> then
> echo ""
> - echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write "
> - echo -e "\t permissions, but operation failed [ Physical Directory ]"
> - else
> - echo ""
> echo "SUCCESS: ACL_USER_OBJ entry contains the owner write permissions,"
> echo -e "\t operation success [ Physical Directory ]"
> + else
> + echo ""
> + echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write "
> + echo -e "\t permissions, but operation failed [ Physical Directory ]"
> fi
>
> touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null
> if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ]
> then
> echo ""
> - echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write "
> - echo -e "\t permissions, but operation failed [ Symlink Directory ]"
> - else
> - echo ""
> echo "SUCCESS: ACL_USER_OBJ entry contains the owner write permissions,"
> echo -e "\t operation success [ Symlink Directory ]"
> + else
> + echo ""
> + echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the owner write "
> + echo -e "\t permissions, but operation failed [ Symlink Directory ]"
> fi
>
> TACL_USER1
> --
> 1.9.3
>
> --
> George Wang 王旭
>
> Kernel Quantity Engineer
> Red Hat Software (Beijing) Co.,Ltd
> IRC:xuw
> Tel:+86-010-62608041
> Phone:15901231579
> 9/F, Tower C, Raycom
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh
2014-10-10 8:06 ` [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh Xu Wang
2014-10-14 7:51 ` Eryu Guan
@ 2014-10-14 12:57 ` Jan Stancek
1 sibling, 0 replies; 3+ messages in thread
From: Jan Stancek @ 2014-10-14 12:57 UTC (permalink / raw)
To: Xu Wang; +Cc: ltp-list
----- Original Message -----
> From: "Xu Wang" <xuw@redhat.com>
> To: ltp-list@lists.sourceforge.net
> Sent: Friday, 10 October, 2014 10:06:48 AM
> Subject: [LTP] [PATCH] fs: Fix the check bug in testcases/kernel/fs/acl/tacl_xattr.sh
>
> From fbc38181f0504d5e92def922977da2dd0ae0ee8b Mon Sep 17 00:00:00 2001
> From: George Wang <xuw@redhat.com>
> Date: Fri, 10 Oct 2014 15:59:16 +0800
> Subject: [PATCH] fs: Fix the check bug in
> testcases/kernel/fs/acl/tacl_xattr.sh
>
> Signed-off-by: George Wang <xuw@redhat.com>
> ---
> testcases/kernel/fs/acl/tacl_xattr.sh | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/testcases/kernel/fs/acl/tacl_xattr.sh
> b/testcases/kernel/fs/acl/tacl_xattr.sh
> index 99f6a95..5a60a04 100755
> --- a/testcases/kernel/fs/acl/tacl_xattr.sh
> +++ b/testcases/kernel/fs/acl/tacl_xattr.sh
> @@ -247,24 +247,24 @@ su - tacluser1 << TACL_USER1
Also I suspect that this line is a typo:
touch $CUR_PATH/tacl/mount-ext2/shared/team1/newfil1 2> /dev/null
^^ test tries to touch "newfil1"
if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
^^ and then check for "newfile1"
Regards,
Jan
> if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile1 ]
> then
> echo ""
> - echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the
> owner write "
> - echo -e "\t permissions, but operation failed [ Physical Directory ]"
> - else
> - echo ""
> echo "SUCCESS: ACL_USER_OBJ entry contains the owner write
> permissions,"
> echo -e "\t operation success [ Physical Directory ]"
> + else
> + echo ""
> + echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the
> owner write "
> + echo -e "\t permissions, but operation failed [ Physical Directory ]"
> fi
>
> touch $CUR_PATH/tacl/mount-ext2/shared/symlinkdir1/newfil2 2> /dev/null
> if [ -e $CUR_PATH/tacl/mount-ext2/shared/team1/newfile2 ]
> then
> echo ""
> - echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the
> owner write "
> - echo -e "\t permissions, but operation failed [ Symlink Directory ]"
> - else
> - echo ""
> echo "SUCCESS: ACL_USER_OBJ entry contains the owner write
> permissions,"
> echo -e "\t operation success [ Symlink Directory ]"
> + else
> + echo ""
> + echo "FAILED: [ touch ] ACL_USER_OBJ entry already contains the
> owner write "
> + echo -e "\t permissions, but operation failed [ Symlink Directory ]"
> fi
>
> TACL_USER1
> --
> 1.9.3
>
> --
> George Wang 王旭
>
> Kernel Quantity Engineer
> Red Hat Software (Beijing) Co.,Ltd
> IRC:xuw
> Tel:+86-010-62608041
> Phone:15901231579
> 9/F, Tower C, Raycom
>
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 3+ messages in thread