From: Marius Kittler <mkittler@suse.de>
To: ltp <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH] Use correct ioctl request for termios
Date: Mon, 04 Sep 2023 17:18:00 +0200 [thread overview]
Message-ID: <4508326.LvFx2qVVIh@linux-9lzf> (raw)
In-Reply-To: <ZPXyE9O38JHxfiV0@yuki>
Am Montag, 4. September 2023, 17:04:51 CEST schrieb Cyril Hrubis:
>
> I guess that it would be cleaner to keep the single request, but define
> the s_tio as a void * here.
>
> That way we can add test on a separate lines:
>
> {&bfd, TCGETA, &termio, EBADF},
> {&bfd, TCGETS, &termios, EBADF},
> ...
>
But we have currently 4 tests that are all executed via both termio and
termios. To keep this kind of coverage we would need to duplicate all of those
lines. That would be 4 new test lines in total. Is that what you're
suggesting? I'm just asking twice because I'm not sure whether it is better
(but don't have a strong opinion).
By the way, how would I submit an amendment here? Just submit the amended
commit again in the same way (I used `git send-email --
to=ltp@lists.linux.it`)?
And how is this merged? I saw that in another case patchwork was used? How
does that come into play?
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-09-04 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 14:50 [LTP] [PATCH] Use correct ioctl request for termios Marius Kittler
2023-09-04 15:04 ` Cyril Hrubis
2023-09-04 15:18 ` Marius Kittler [this message]
2023-09-04 16:11 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4508326.LvFx2qVVIh@linux-9lzf \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox