public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Jan Stancek <jstancek@redhat.com>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] tst_test: Allow to set timeout from test setup()
Date: Wed, 3 Aug 2016 11:44:31 -0400 (EDT)	[thread overview]
Message-ID: <456027902.863199.1470239071534.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160803153419.GC25589@rei>





----- Original Message -----
> From: "Cyril Hrubis" <chrubis@suse.cz>
> To: "Jan Stancek" <jstancek@redhat.com>
> Cc: ltp@lists.linux.it
> Sent: Wednesday, 3 August, 2016 5:34:19 PM
> Subject: Re: [PATCH] tst_test: Allow to set timeout from test setup()
> 
> Hi!
> > > I think that it will be safer to have it run with either with a default
> > > timeout or with a test->timeout. And that is the whole point of setting
> > > the timeout twice in case that we call tst_set_timeout() in the test
> > > setup().
> > 
> > Good point, so setting timeout twice seems unavoidable.
> > But I'm still thinking about actions needed to set timeout
> > that are now not part of tst_set_timeout(). Would it make sense
> > to bring those in?
> 
> Looks good to me. I will merge your changes into my patch, add your
> Signed-off-by and push it, OK?

Fine by me.

Regards,
Jan

> 
> --
> Cyril Hrubis
> chrubis@suse.cz
> 

      reply	other threads:[~2016-08-03 15:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03 13:53 [LTP] [PATCH] tst_test: Allow to set timeout from test setup() Cyril Hrubis
2016-08-03 14:38 ` Jan Stancek
2016-08-03 15:06   ` Cyril Hrubis
2016-08-03 15:33     ` Jan Stancek
2016-08-03 15:34       ` Cyril Hrubis
2016-08-03 15:44         ` Jan Stancek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=456027902.863199.1470239071534.JavaMail.zimbra@redhat.com \
    --to=jstancek@redhat.com \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox