From: Marius Kittler <mkittler@suse.de>
To: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 0/2] swapon01: Test on all filesystems, cleanup
Date: Thu, 12 Oct 2023 11:28:51 +0200 [thread overview]
Message-ID: <4867816.31r3eYUQgx@linux-9lzf> (raw)
In-Reply-To: <20231011162428.583911-1-pvorel@suse.cz>
I guess the code would work and looks generally good to merge. In fact, I
tested `.all_filesystems = 1` myself yesterday. It is just the question
whether we actually want it. Is there really coverage to be gained (or does
the kernel just the same under the hood anyway regardless of the filesystem)?
> Test on all filesystems to increase coverage. btrfs and tmpfs
> currently does not support swap file, but keep it in case this get
> changed in the future.
Considering btrfs does not support it I guess that means the kernel does
indeed different things under the hood so the coverage might be beneficial. (If
it was just about tmpfs then I'd say it makes no sense to put a swapfile there
in any case and it will therefore likely never be supported.)
Reviewed-by: Marius Kittler <mkittler@suse.de>
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-10-12 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 16:24 [LTP] [PATCH 0/2] swapon01: Test on all filesystems, cleanup Petr Vorel
2023-10-11 16:24 ` [LTP] [PATCH 1/2] swapon01: Test on all filesystems Petr Vorel
2024-01-19 11:42 ` Cyril Hrubis
2024-01-19 12:26 ` Li Wang
2024-01-19 14:33 ` Petr Vorel
2024-01-19 14:53 ` Cyril Hrubis
2023-10-11 16:24 ` [LTP] [PATCH 2/2] swapon01: Simplify code, add copyright Petr Vorel
2024-01-19 11:59 ` Cyril Hrubis
2024-01-19 13:36 ` Petr Vorel
2023-10-12 9:28 ` Marius Kittler [this message]
2024-01-12 7:18 ` [LTP] [PATCH 0/2] swapon01: Test on all filesystems, cleanup Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4867816.31r3eYUQgx@linux-9lzf \
--to=mkittler@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox