From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2 2/2] lib: Create tst_tmpdir.h
Date: Tue, 25 Jun 2024 17:11:26 +0200 [thread overview]
Message-ID: <4884009.OV4Wx5bFTl@localhost> (raw)
In-Reply-To: <20240621105957.671338-3-pvorel@suse.cz>
Hi Petr,
...
> diff --git a/lib/tst_tmpdir.c b/lib/tst_tmpdir.c
> index bcc788390..0f1b15ca4 100644
> --- a/lib/tst_tmpdir.c
> +++ b/lib/tst_tmpdir.c
> @@ -72,6 +72,7 @@
>
> #include "test.h"
> #include "safe_macros.h"
> +#include "tst_tmpdir.h"
> #include "ltp_priv.h"
> #include "lapi/futex.h"
>
I think we also need to include tst_tmpdir.h in tst_test.h, else we are
introducing implicit declaration warning in all tests where we use
tst_purge_dir() function.
e.g. creat08.c
creat08.c: In function ‘run’:
creat08.c:128:9: warning: implicit declaration of function ‘tst_purge_dir’ [-Wimplicit-function-declaration]
128 | tst_purge_dir(tmpdir);
| ^~~~~~~~~~~~~
CC testcases/kernel/syscalls/creat/creat08
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2024-06-25 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:59 [LTP] [PATCH v2 0/2] Create tst_tmpdir.h Petr Vorel
2024-06-21 10:59 ` [LTP] [PATCH v2 1/2] tst_tmpdir: Remove NULL from static Petr Vorel
2024-06-21 10:59 ` [LTP] [PATCH v2 2/2] lib: Create tst_tmpdir.h Petr Vorel
2024-06-25 15:11 ` Avinesh Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4884009.OV4Wx5bFTl@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox