* [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel
@ 2024-09-04 12:36 Petr Vorel
2024-09-05 14:12 ` Avinesh Kumar
2024-09-10 8:46 ` Martin Doucha
0 siblings, 2 replies; 4+ messages in thread
From: Petr Vorel @ 2024-09-04 12:36 UTC (permalink / raw)
To: ltp; +Cc: Jan Kara
Kernel commit e730558adffb ("fsnotify: consistent behavior for parent
not watching children") will not be backported to SLE15-SP[45] v5.14
based kernel, therefore skip it for kernel < 5.19 (the original mainline
kernel which brought the functionality.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/syscalls/fanotify/fanotify09.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
index 48b198b941..72e9239897 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify09.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
@@ -379,7 +379,12 @@ static void test_fanotify(unsigned int n)
return;
}
- if (tc->ignore && tst_kvercmp(5, 10, 0) < 0) {
+ static struct tst_kern_exv kvers[] = {
+ {"SLES", "5.19"},
+ {NULL, NULL}
+ };
+
+ if (tc->ignore && tst_kvercmp2(5, 10, 0, kvers) < 0) {
tst_res(TCONF, "ignored mask on parent dir has undefined "
"behavior on kernel < 5.10");
return;
--
2.45.2
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel
2024-09-04 12:36 [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel Petr Vorel
@ 2024-09-05 14:12 ` Avinesh Kumar
2024-09-10 8:46 ` Martin Doucha
1 sibling, 0 replies; 4+ messages in thread
From: Avinesh Kumar @ 2024-09-05 14:12 UTC (permalink / raw)
To: Petr Vorel; +Cc: Jan Kara, ltp
Hi,
Reviewed-by: Avinesh Kumar <akumar@suse.de>
On Wednesday, September 4, 2024 2:36:04 PM GMT+2 Petr Vorel wrote:
> Kernel commit e730558adffb ("fsnotify: consistent behavior for parent
> not watching children") will not be backported to SLE15-SP[45] v5.14
> based kernel, therefore skip it for kernel < 5.19 (the original mainline
> kernel which brought the functionality.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/syscalls/fanotify/fanotify09.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
> index 48b198b941..72e9239897 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify09.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
> @@ -379,7 +379,12 @@ static void test_fanotify(unsigned int n)
> return;
> }
>
> - if (tc->ignore && tst_kvercmp(5, 10, 0) < 0) {
> + static struct tst_kern_exv kvers[] = {
> + {"SLES", "5.19"},
> + {NULL, NULL}
> + };
> +
> + if (tc->ignore && tst_kvercmp2(5, 10, 0, kvers) < 0) {
> tst_res(TCONF, "ignored mask on parent dir has undefined "
> "behavior on kernel < 5.10");
> return;
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
* [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel
@ 2024-09-06 7:25 Petr Vorel
0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2024-09-06 7:25 UTC (permalink / raw)
To: ltp; +Cc: Jan Kara
Kernel commit e730558adffb ("fsnotify: consistent behavior for parent
not watching children") will not be backported to SLE15-SP[45] v5.14
based kernel, therefore skip it for kernel < 5.19 (the original mainline
kernel which brought the functionality.
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
testcases/kernel/syscalls/fanotify/fanotify09.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
index 48b198b941..72e9239897 100644
--- a/testcases/kernel/syscalls/fanotify/fanotify09.c
+++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
@@ -379,7 +379,12 @@ static void test_fanotify(unsigned int n)
return;
}
- if (tc->ignore && tst_kvercmp(5, 10, 0) < 0) {
+ static struct tst_kern_exv kvers[] = {
+ {"SLES", "5.19"},
+ {NULL, NULL}
+ };
+
+ if (tc->ignore && tst_kvercmp2(5, 10, 0, kvers) < 0) {
tst_res(TCONF, "ignored mask on parent dir has undefined "
"behavior on kernel < 5.10");
return;
--
2.45.2
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel
2024-09-04 12:36 [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel Petr Vorel
2024-09-05 14:12 ` Avinesh Kumar
@ 2024-09-10 8:46 ` Martin Doucha
1 sibling, 0 replies; 4+ messages in thread
From: Martin Doucha @ 2024-09-10 8:46 UTC (permalink / raw)
To: Petr Vorel, ltp; +Cc: Jan Kara
Hi,
I've added fanotify09 to our internal whitelist for SLES with the
relevant kernels. This patch is no longer needed.
On 04. 09. 24 14:36, Petr Vorel wrote:
> Kernel commit e730558adffb ("fsnotify: consistent behavior for parent
> not watching children") will not be backported to SLE15-SP[45] v5.14
> based kernel, therefore skip it for kernel < 5.19 (the original mainline
> kernel which brought the functionality.
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/syscalls/fanotify/fanotify09.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/fanotify/fanotify09.c b/testcases/kernel/syscalls/fanotify/fanotify09.c
> index 48b198b941..72e9239897 100644
> --- a/testcases/kernel/syscalls/fanotify/fanotify09.c
> +++ b/testcases/kernel/syscalls/fanotify/fanotify09.c
> @@ -379,7 +379,12 @@ static void test_fanotify(unsigned int n)
> return;
> }
>
> - if (tc->ignore && tst_kvercmp(5, 10, 0) < 0) {
> + static struct tst_kern_exv kvers[] = {
> + {"SLES", "5.19"},
> + {NULL, NULL}
> + };
> +
> + if (tc->ignore && tst_kvercmp2(5, 10, 0, kvers) < 0) {
> tst_res(TCONF, "ignored mask on parent dir has undefined "
> "behavior on kernel < 5.10");
> return;
--
Martin Doucha mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic
--
Mailing list info: https://lists.linux.it/listinfo/ltp
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-09-10 8:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-04 12:36 [LTP] [PATCH 1/1] fanotify09: Skip testing e730558adffb on SLE < 5.19 kernel Petr Vorel
2024-09-05 14:12 ` Avinesh Kumar
2024-09-10 8:46 ` Martin Doucha
-- strict thread matches above, loose matches on Subject: below --
2024-09-06 7:25 Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox