Re: [LTP] [RFC][PATCH] Add cpu architecrute check

[Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>]

Hi,

Mike Frysinger wrote:
> On Thursday 04 June 2009 03:23:17 Nobuhiro Iwamatsu wrote:
>> --- a/Makefile
>> +++ b/Makefile
>> +ifndef ARCH
>> +# copy from Makefile in linux kernel
>> +ARCH := $(shell uname -m
> 
> executing uname to detect build/target systems is never acceptable.

I see.

> 
>> --- a/testcases/kernel/syscalls/fallocate/Makefile
>> +++ b/testcases/kernel/syscalls/fallocate/Makefile
>> @@ -20,8 +20,14 @@
>>  CFLAGS += -I../../../../include -Wall
>>  LDLIBS += -L../../../../lib -lltp
>>
>> +# This system call is suported in i386, x86_64 and ppc only.
>> +ifneq (,$(findstring $(ARCH), i386 x86_64 ppc))
>>  SRCS    = $(wildcard *.c)
>>  TARGETS = $(patsubst %.c,%,$(SRCS))
>> +else
>> +SRCS    =
>> +TARGETS =
>> +endif
> 
> atm, better to put the ifdef logic into the test itself.  look at some of the 
> other tests that get stubbed out in the syscalls dir.
I see, again.
I check your point and Subrata's patch.
Thank you.

Best regards,
 Nobuhiro


------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises 
looking to deploy the next generation of Solaris that includes the latest 
innovations from Sun and the OpenSource community. Download a copy and 
enjoy capabilities such as Networking, Storage and Virtualization. 
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list