public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Vijay Kumar <vijaykumar@bravegnu.org>
To: LTP List <ltp-list@lists.sourceforge.net>
Subject: [LTP] [RFC] Using checkpatch.pl
Date: Sun, 14 Jun 2009 22:03:17 +0530	[thread overview]
Message-ID: <4A35264D.10800@bravegnu.org> (raw)

Hi everyone,
Michal Simek patched most of the LTP code base to use the Linux kernel
coding style. But unfortunately new patches, that are flowing in, seem
to add coding style violations. It is better to prevent new style
violations than to fix them later on.

The kernel developers use a perl script called checkpatch.pl to
identify style violations in patches. We could use the same script to
check our patches, as well. The script uses files from the kernel to
do kernel specific checks. This can be disabled by using the --no-tree
option. So to check an LTP patch

$ checkpatch.pl --no-tree ltp-patch

If everybody is OK with it we can add the script to the LTP source
tree, so that everyone checks their patches against the same
script. And Subrata can easily check for style violations before
merging the patch.

In the future, we could also customize the script to do userspace/LTP
specific checks, like missing mode argument when open() is invoked
with O_CREAT flag.

Please do send in your suggestions.

Regards,
Vijay

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2009-06-14 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-14 16:33 Vijay Kumar [this message]
2009-06-15  2:38 ` [LTP] [RFC] Using checkpatch.pl Garrett Cooper
2009-06-15  7:17   ` Mike Frysinger
2009-06-18 17:31 ` Subrata Modak
2009-06-30  7:41   ` Subrata Modak
2009-06-30  8:37     ` Vijay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A35264D.10800@bravegnu.org \
    --to=vijaykumar@bravegnu.org \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox