From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-4.v28.ch3.sourceforge.com ([172.29.28.124] helo=mx.sourceforge.net) by 235xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MGHtx-0005Yd-O2 for ltp-list@lists.sourceforge.net; Mon, 15 Jun 2009 19:31:29 +0000 Received: from [207.126.144.137] (helo=eu1sys200aog114.obsmtp.com) by 1b2kzd1.ch3.sourceforge.com with smtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1MGHtv-0008Ee-Uc for ltp-list@lists.sourceforge.net; Mon, 15 Jun 2009 19:31:29 +0000 Message-ID: <4A36A149.3020800@st.com> Date: Mon, 15 Jun 2009 21:30:17 +0200 From: Francesco RUNDO MIME-Version: 1.0 References: <4A267148.8000700@st.com> <1244114998.4879.25.camel@subratamodak.linux.ibm.com> <4A30B95F.4090903@st.com> <1245093390.4871.50.camel@subratamodak.linux.ibm.com> In-Reply-To: <1245093390.4871.50.camel@subratamodak.linux.ibm.com> Subject: Re: [LTP] kernel/controllers/ testcase and CGROUPS support List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4280760489122151613==" Errors-To: ltp-list-bounces@lists.sourceforge.net To: subrata@linux.vnet.ibm.com Cc: ltp-list@lists.sourceforge.net This is a multi-part message in MIME format. --===============4280760489122151613== Content-Type: multipart/alternative; boundary="------------080106030104020306000105" This is a multi-part message in MIME format. --------------080106030104020306000105 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Subrata, Ok. Thanks so much for your support. Best Regards Francesco Rundo Subrata Modak wrote: >On Thu, 2009-06-11 at 09:59 +0200, Francesco RUNDO wrote: > > >>Hi Subrata, >> >>please, replace on the LTP main the previous patch with ones attached. >>The attached patch add the right labels of ifdef. >> >> > >Ok. I reverted the earlier one and applied this one. Please check the >CVS and let me know if everything is fine. > >Regards-- >Subrata > > > >>Sorry for that. >> >>Thanks in advance. >>-- >>Francesco Rundo >> >>Subrata Modak wrote: >> >> >>>On Wed, 2009-06-03 at 14:49 +0200, Francesco RUNDO wrote: >>> >>> >>> >>>>This patch allows the cross-build of kernel/controllers (cgroups >>>>tests) testcase changing the policy to check the cgroups capability at >>>>build-time. >>>>Signed-off-by: Francesco Rundo >>>> >>>> >>>> >>>Great if that helps your CROSS_COMPILE environment. Merged. >>> >>>Regards-- >>>Subrata >>> >>> >>> >>> >>>>--- >>>>ltp-full-20090430-cross/testcases/kernel/controllers/Makefile.orig 2009-05-26 15:37:35.140000000 +0200 >>>>+++ >>>>ltp-full-20090430-cross/testcases/kernel/controllers/Makefile 2009-05-28 13:36:36.669998000 +0200 >>>>@@ -1,10 +1,26 @@ >>>>+ifdef $(CROSS_COMPILE) >>>>+CHECK_CGROUP := $(shell test -f >>>>$(TARGET_DIR)/usr/include/linux/cgroupstats.h && echo 'cgroup') >>>>+else >>>> CHECK_CGROUP := $(shell test -f /proc/cgroups && echo 'cgroup') >>>> CHECK_CPUCTL := $(shell grep -w cpu /proc/cgroups 2>/dev/null|cut >>>>-f1) >>>> CHECK_MEMCTL := $(shell grep -w memory /proc/cgroups 2>/dev/null|cut >>>>-f1) >>>> CHECK_BLOCKIOCTL := $(shell grep -w blockio /proc/cgroups >>>>2>/dev/null|cut -f1) >>>> CHECK_FREEZER := $(shell grep -w freezer /proc/cgroups 2>/dev/null| >>>>cut -f1) >>>> CHECK_CPUSETCTL = $(shell grep -w cpuset /proc/cgroups 2>/dev/null| >>>>cut -f1) >>>>+endif >>>> >>>>+ifdef $(CROSS_COMPILE) >>>>+ifeq ($(CHECK_CGROUP),cgroup) >>>>+SUBDIRS += cgroup >>>>+SUBDIRS += cpuctl >>>>+SUBDIRS += memctl >>>>+SUBDIRS += io-throttle >>>>+SUBDIRS += freezer >>>>+SUBDIRS += cpuset >>>>+else >>>>+$(info "Kernel is not compiled with control cgroup support") >>>>+endif >>>>+else >>>> ifeq ($(CHECK_CGROUP),cgroup) >>>> SUBDIRS += cgroup >>>> else >>>>@@ -36,6 +52,7 @@ >>>> else >>>> $(info "Kernel is not compiled with cpuset resource controller >>>>support") >>>> endif >>>>+endif >>>> >>>> # If at least one of the controllers is available then build >>>>libcontrollers. >>>> ifneq ($(SUBDIRS),) >>>> >>>> >>>> >>> >>> >>> >>plain text document attachment >>(ltp-full-20090430-fix-cgroups-testcase.patch) >>This patch allows the cross-build of kernel/controllers (cgroups tests) testcase changing the policy to check the cgroups capability at build-time. >>Signed-off-by: Francesco Rundo >>--- ltp-full-20090430-cross/testcases/kernel/controllers/Makefile.orig 2009-05-26 15:37:35.140000000 +0200 >>+++ ltp-full-20090430-cross/testcases/kernel/controllers/Makefile 2009-05-28 13:36:36.669998000 +0200 >>@@ -1,10 +1,26 @@ >>+ifdef CROSS_COMPILE >>+CHECK_CGROUP := $(shell test -f $(TARGET_DIR)/usr/include/linux/cgroupstats.h && echo 'cgroup') >>+else >> CHECK_CGROUP := $(shell test -f /proc/cgroups && echo 'cgroup') >> CHECK_CPUCTL := $(shell grep -w cpu /proc/cgroups 2>/dev/null|cut -f1) >> CHECK_MEMCTL := $(shell grep -w memory /proc/cgroups 2>/dev/null|cut -f1) >> CHECK_BLOCKIOCTL := $(shell grep -w blockio /proc/cgroups 2>/dev/null|cut -f1) >> CHECK_FREEZER := $(shell grep -w freezer /proc/cgroups 2>/dev/null| cut -f1) >> CHECK_CPUSETCTL = $(shell grep -w cpuset /proc/cgroups 2>/dev/null|cut -f1) >>+endif >> >>+ifdef CROSS_COMPILE >>+ifeq ($(CHECK_CGROUP),cgroup) >>+SUBDIRS += cgroup >>+SUBDIRS += cpuctl >>+SUBDIRS += memctl >>+SUBDIRS += io-throttle >>+SUBDIRS += freezer >>+SUBDIRS += cpuset >>+else >>+$(info "Kernel is not compiled with control cgroup support") >>+endif >>+else >> ifeq ($(CHECK_CGROUP),cgroup) >> SUBDIRS += cgroup >> else >>@@ -36,6 +52,7 @@ >> else >> $(info "Kernel is not compiled with cpuset resource controller support") >> endif >>+endif >> >> # If at least one of the controllers is available then build libcontrollers. >> ifneq ($(SUBDIRS),) >> >> > > > > --------------080106030104020306000105 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit Subrata,
Ok.
Thanks so much for your support.

Best Regards
Francesco Rundo

Subrata Modak wrote:
On Thu, 2009-06-11 at 09:59 +0200, Francesco RUNDO wrote:
  
Hi Subrata,

please, replace on the LTP main the previous patch with ones attached.
The attached patch add the right labels of ifdef.
    

Ok. I reverted the earlier one and applied this one. Please check the
CVS and let me know if everything is fine.

Regards--
Subrata

  
Sorry for that.

Thanks in advance.
--
Francesco Rundo

Subrata Modak wrote: 
    
On Wed, 2009-06-03 at 14:49 +0200, Francesco RUNDO wrote:
  
      
This patch allows the cross-build of kernel/controllers (cgroups
tests) testcase changing the policy to check the cgroups capability at
build-time.
Signed-off-by: Francesco Rundo <francesco.rundo@st.com>
    
        
Great if that helps your CROSS_COMPILE environment. Merged.

Regards--
Subrata

  
      
---
ltp-full-20090430-cross/testcases/kernel/controllers/Makefile.orig  2009-05-26 15:37:35.140000000 +0200
+++
ltp-full-20090430-cross/testcases/kernel/controllers/Makefile       2009-05-28 13:36:36.669998000 +0200
@@ -1,10 +1,26 @@
+ifdef $(CROSS_COMPILE)
+CHECK_CGROUP := $(shell test -f
$(TARGET_DIR)/usr/include/linux/cgroupstats.h && echo 'cgroup')
+else
 CHECK_CGROUP := $(shell test -f /proc/cgroups && echo 'cgroup')
 CHECK_CPUCTL := $(shell grep -w cpu /proc/cgroups 2>/dev/null|cut
-f1)
 CHECK_MEMCTL := $(shell grep -w memory /proc/cgroups 2>/dev/null|cut
-f1)
 CHECK_BLOCKIOCTL := $(shell grep -w blockio /proc/cgroups
2>/dev/null|cut -f1)
 CHECK_FREEZER := $(shell grep -w freezer /proc/cgroups 2>/dev/null|
cut -f1)
 CHECK_CPUSETCTL = $(shell grep -w cpuset /proc/cgroups 2>/dev/null|
cut -f1)
+endif

+ifdef $(CROSS_COMPILE)
+ifeq ($(CHECK_CGROUP),cgroup)
+SUBDIRS += cgroup
+SUBDIRS += cpuctl
+SUBDIRS += memctl
+SUBDIRS += io-throttle
+SUBDIRS += freezer
+SUBDIRS += cpuset
+else
+$(info "Kernel is not compiled with control cgroup support")
+endif
+else
 ifeq ($(CHECK_CGROUP),cgroup)
 SUBDIRS += cgroup
 else
@@ -36,6 +52,7 @@
 else
 $(info "Kernel is not compiled with cpuset resource controller
support")
 endif
+endif

 # If at least one of the controllers is available then build
libcontrollers.
 ifneq ($(SUBDIRS),)
    
        
  
      
plain text document attachment
(ltp-full-20090430-fix-cgroups-testcase.patch)
This patch allows the cross-build of kernel/controllers (cgroups tests) testcase changing the policy to check the cgroups capability at build-time.
Signed-off-by: Francesco Rundo <francesco.rundo@st.com>
--- ltp-full-20090430-cross/testcases/kernel/controllers/Makefile.orig	2009-05-26 15:37:35.140000000 +0200
+++ ltp-full-20090430-cross/testcases/kernel/controllers/Makefile	2009-05-28 13:36:36.669998000 +0200
@@ -1,10 +1,26 @@
+ifdef CROSS_COMPILE
+CHECK_CGROUP := $(shell test -f $(TARGET_DIR)/usr/include/linux/cgroupstats.h && echo 'cgroup')
+else
 CHECK_CGROUP := $(shell test -f /proc/cgroups && echo 'cgroup')
 CHECK_CPUCTL := $(shell grep -w cpu /proc/cgroups 2>/dev/null|cut -f1)
 CHECK_MEMCTL := $(shell grep -w memory /proc/cgroups 2>/dev/null|cut -f1)
 CHECK_BLOCKIOCTL := $(shell grep -w blockio /proc/cgroups 2>/dev/null|cut -f1)
 CHECK_FREEZER := $(shell grep -w freezer /proc/cgroups 2>/dev/null| cut -f1)
 CHECK_CPUSETCTL = $(shell grep -w cpuset /proc/cgroups 2>/dev/null|cut -f1)
+endif

+ifdef CROSS_COMPILE
+ifeq ($(CHECK_CGROUP),cgroup)
+SUBDIRS += cgroup
+SUBDIRS += cpuctl
+SUBDIRS += memctl
+SUBDIRS += io-throttle
+SUBDIRS += freezer
+SUBDIRS += cpuset
+else
+$(info "Kernel is not compiled with control cgroup support")
+endif
+else
 ifeq ($(CHECK_CGROUP),cgroup)
 SUBDIRS += cgroup
 else
@@ -36,6 +52,7 @@
 else
 $(info "Kernel is not compiled with cpuset resource controller support")
 endif
+endif

 # If at least one of the controllers is available then build libcontrollers.
 ifneq ($(SUBDIRS),)
--------------080106030104020306000105-- --===============4280760489122151613== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects --===============4280760489122151613== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list --===============4280760489122151613==--