Hi Garrett,

thanks for your comment. Below, my consideration:

Garrett Cooper wrote:

On Mon, Jul 6, 2009 at 4:38 AM, Francesco RUNDO<francesco.rundo@st.com> wrote:

Hi Gowri,

I've already fixed the same issue you reported. I've tested it successfully.

Subrata has already merged my patch (please, find it in attachment).

Please, check it before to submit another patch.


At the end of the day, the real problem is that we're not using the
--with- functionality in autoconf, e.g. --with-cgroups, and instead
we're hacking a lot of noise into Makefile's.

Yes, you're right but your advice can't be applicable in the system in which autoconf is not supported/used to build LTP (a possible scenario in the embedded system).


Also, you could have called SUBDIRS += once, like so:

+SUBDIRS += cgroup cpuctl memctl io-throttle freezer cpuset

I can tell at first glance that that Makefile is a mess anyhow,
because it's referencing _hardcoded_ /proc references and as such will
fail to cross-compile properly if the target or the host are setup
differently from one another, in the following two scenarios:

Yes, check at "/proc" isn't safe as can't be applicable in case of cross-compilation made off-line on the host.
I have provided a "work-around" patch to allow off-line cross-compilation trying to reduce the number of changes to be applied to the Makefile.

Regards
Francesco Rundo