Re: [LTP] [PATCH] cgroups: conditionally enable building cgroup tests

Garrett Cooper
2009-07-06T17:28:16Z

On Mon, Jul 6, 2009 at 4:38 AM, Francesco RUNDO<francesco.rundo@st.com> wrote:
> Hi Gowri,
>
> I've already fixed the same issue you reported. I've tested it successfully.
>
> Subrata has already merged my patch (please, find it in attachment).
>
> Please, check it before to submit another patch.

At the end of the day, the real problem is that we're not using the
--with- functionality in autoconf, e.g. --with-cgroups, and instead
we're hacking a lot of noise into Makefile's.

Also, you could have called SUBDIRS += once, like so:

+SUBDIRS += cgroup cpuctl memctl io-throttle freezer cpuset

I can tell at first glance that that Makefile is a mess anyhow,
because it's referencing _hardcoded_ /proc references and as such will
fail to cross-compile properly if the target or the host are setup
differently from one another, in the following two scenarios:

1. host has cgroups support and target doesn't. host will force the
cgroups testcases to compile, and we'll either run into make failures,
or CONF (if the source is setup properly).
2. target has cgroups support and host doesn't. target will miss out
on cgroups testcases.

Thanks,
-Garrett