Re: [LTP] [PATCH] fix the system call number of exit_group01

Garrett Cooper
2009-07-19T05:35:51Z

On Sat, Jul 18, 2009 at 10:22 PM, Mike Frysinger<vapier@gentoo.org> wrote:
> On Sunday 19 July 2009 00:47:29 Garrett Cooper wrote:
>> On Wed, Jul 15, 2009 at 5:37 PM, Wei Yongjun<yjwei@cn.fujitsu.com> wrote:
>> > The system call number is depend on the system architecture, not always
>> > 252. This patch fixed the problem.
>> >
>> > --- a/testcases/kernel/syscalls/exit_group/exit_group01.c
>> > -                               TEST(syscall(252,4));
>> > +                               TEST(syscall(__NR_exit_group,4));
>>
>>     The best way to do this (IMHO) may be to add the relevant syscall
>> number to the architecture specific .in file in
>> testcases/kernel/include. Do you have the syscall number for your
>> architecture?
>
> both should be done.  syscall() should never be used with a hardcoded #.

Agreed.
-Garrett