Re: [LTP] [PATCH] Fix to set the signal handler of SIGINT in mq_timedreceive01

Michal Simek
2009-07-21T13:07:41Z

Hi,

Please fix coding style violation.
Use tab instead of spaces.
Subrata should reject this patch with bad coding style.
Can you please fix it?

Thanks,
Michal

> The test case mq_timedreceive01 does not register the signal
> handler of SIGINT, so the problam will be terminated by SIGINT
> from child process.
>
> This patch fixed the problem.
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> diff --git a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> index dadc38d..beeb298 100644
> --- a/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> +++ b/testcases/kernel/syscalls/mq_timedreceive/mq_timedreceive01.c
> @@ -106,6 +106,14 @@ extern void cleanup() {
> tst_exit();
> }
>
> +/*
> + * sighandler()
> + */
> +void sighandler(int sig)
> +{
> + return;
> +}
> +
> /* Local Functions */
> /******************************************************************************/
> /* */
> @@ -126,6 +134,7 @@ extern void cleanup() {
> /******************************************************************************/
> void setup() {
> /* Capture signals if any */
> + signal(SIGINT, sighandler);
> /* Create temporary directories */
> TEST_PAUSE;
> tst_tmpdir();
> @@ -432,17 +441,6 @@ EXIT:
> return result;
> }
>
> -/*
> - * sighandler()
> - */
> -void sighandler(int sig)
> -{
> - if (sig == SIGINT)
> - return;
> - // NOTREACHED
> - return;
> -}
> -
>
>
> /*
>
>
>
>
>
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge
> This is your chance to win up to $100,000 in prizes! For a limited time,
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>

--
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663

------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize
details at: http://p.sf.net/sfu/Challenge