public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
* [LTP] [PATCH] Fix the failure of get_mempolicy01 test case
@ 2009-07-21  3:07 Wei Yongjun
  2009-07-30 18:28 ` Subrata Modak
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-07-21  3:07 UTC (permalink / raw)
  To: ltp-list

Test case get_mempolicy01 failure because of the the nodemask
is not used when from_node is NONE type. If the from_node is
NONE, nodemask_equal() is not need.

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

diff --git a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
index 2201bf4..aa0b14b 100644
--- a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
+++ b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
@@ -337,7 +337,7 @@ static int do_test(struct test_case *tc)
         // When policy equals MPOL_DEFAULT, then get_mempolicy not return node
         if (tc->policy == MPOL_DEFAULT)
                 nodemask_zero(&nodemask);
-        cmp_ok = tc->policy == policy && nodemask_equal(&nodemask,&getnodemask);
+        cmp_ok = tc->policy == policy && (tc->from_node == NONE || nodemask_equal(&nodemask,&getnodemask));
         if (opt_debug) {
                 nodemask_dump("nodemask Expect:", &nodemask);
                 nodemask_dump("nodemask Result:", &getnodemask);




------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [LTP] [PATCH] Fix the failure of get_mempolicy01 test case
  2009-07-21  3:07 [LTP] [PATCH] Fix the failure of get_mempolicy01 test case Wei Yongjun
@ 2009-07-30 18:28 ` Subrata Modak
  0 siblings, 0 replies; 2+ messages in thread
From: Subrata Modak @ 2009-07-30 18:28 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: ltp-list

On Tue, 2009-07-21 at 11:07 +0800, Wei Yongjun wrote: 
> Test case get_mempolicy01 failure because of the the nodemask
> is not used when from_node is NONE type. If the from_node is
> NONE, nodemask_equal() is not need.
> 
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>

Thanks.

Regards--
Subrata

> 
> diff --git a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
> index 2201bf4..aa0b14b 100644
> --- a/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
> +++ b/testcases/kernel/syscalls/get_mempolicy/get_mempolicy01.c
> @@ -337,7 +337,7 @@ static int do_test(struct test_case *tc)
>          // When policy equals MPOL_DEFAULT, then get_mempolicy not return node
>          if (tc->policy == MPOL_DEFAULT)
>                  nodemask_zero(&nodemask);
> -        cmp_ok = tc->policy == policy && nodemask_equal(&nodemask,&getnodemask);
> +        cmp_ok = tc->policy == policy && (tc->from_node == NONE || nodemask_equal(&nodemask,&getnodemask));
>          if (opt_debug) {
>                  nodemask_dump("nodemask Expect:", &nodemask);
>                  nodemask_dump("nodemask Result:", &getnodemask);
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Enter the BlackBerry Developer Challenge  
> This is your chance to win up to $100,000 in prizes! For a limited time, 
> vendors submitting new applications to BlackBerry App World(TM) will have
> the opportunity to enter the BlackBerry Developer Challenge. See full prize  
> details at: http://p.sf.net/sfu/Challenge
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-07-30 18:29 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-21  3:07 [LTP] [PATCH] Fix the failure of get_mempolicy01 test case Wei Yongjun
2009-07-30 18:28 ` Subrata Modak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox