Re: [LTP] [PATCH 3/4] Make system enhancements, Draft 3

[Michal Simek <michal.simek@petalogix.com>]

Garrett Cooper wrote:
> On Sun, Jul 19, 2009 at 10:25 PM, Michal
> Simek<michal.simek@petalogix.com> wrote:
>   
>> Garrett Cooper wrote:
>>     
>>> Version 3 of the epic saga: [PATCH 3/4] Make system enhancements.
>>>       
>
> [...]
>
>   
>> I cross compile LTP all the time and Mike do the same for BlackFin.
>> cross-compilation was possible.
>> CROSS_COMPILE=mb-linux-
>> make
>>     
>
> Yes, as Mike corrected me, what I was looking for was `out-of-tree
> build support', where a group (say Montevista) could build more than
> one architecture, or build with more than one compiler / toolchain /
> sys-root using the same source directory.
>   
out-of-tree compilation is nice.

> Well, that and a few Makefiles were broken as far as cross-compilation
> was concerned, in particular library generation on some architectures,
> and hardcoded paths to libraries, host based file scanning heuristics,
> you name it.
>
> This is the first leap forward in correcting all of these things, and
> it will not be the last step that must be made as this project is
> large and the changes / test stimuli are as well.
>
> [...]
>
>   
>>> +LIBOBJS                              := $$(addprefix $$(builddir)/,$$(patsubst %.c,%.o,$$(LIBSRCS)))
>>>
>>>       
>> long line.
>>     
>
> I try my best to do two things with makefile code:
> 1. align Makefile code with single tab, then spaces.
> 2. compress as many statements as possible to reduce the number of
> required evaluation steps, because that can result in interesting
> behavior from make with define blocks...
>
> I will try and compress the space further (that line was tab
> separated) in a style cleanup commit after this is all said and
> committed, if I don't get to it sooner. It's just easier to add and
> delete tabs for now :).
>   
make no sense to send a patch with coding style violation and then send
next patch
which fixed that bad coding style. It is better to do it properly in
first time.
We have to clean whole LTP source code not pollute it.

Michal

> Thanks!
> -Garrett
>   


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663


------------------------------------------------------------------------------
Enter the BlackBerry Developer Challenge  
This is your chance to win up to $100,000 in prizes! For a limited time, 
vendors submitting new applications to BlackBerry App World(TM) will have
the opportunity to enter the BlackBerry Developer Challenge. See full prize  
details at: http://p.sf.net/sfu/Challenge
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list