[LTP] fcntl24,25,26 fail when run on tmpfs

[LTP] fcntl24,25,26 fail when run on tmpfs

[Matt Fleming]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
the host is running on tmpfs. The reason being that, as documented here
http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
cannot work on tmpfs.


[-- Attachment #2: ltp-F_SETLEASE-doesnt-work-on-tmpfs.patch --]
[-- Type: text/x-patch, Size: 2181 bytes --]

Index: testcases/kernel/syscalls/fcntl/fcntl24.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl24.c,v
retrieving revision 1.11
diff -u -r1.11 fcntl24.c
--- testcases/kernel/syscalls/fcntl/fcntl24.c	23 Mar 2009 13:35:41 -0000	1.11
+++ testcases/kernel/syscalls/fcntl/fcntl24.c	29 Jul 2009 14:49:08 -0000
@@ -131,6 +131,14 @@
 			 "Cannot do fcntl on a file located on an NFS filesystem");
 	}
 
+	/*
+	 * check if the current filesystem is tmpfs
+	 */
+	if (tst_is_cwd_tmpfs()) {
+		tst_brkm(TCONF, cleanup,
+			 "Cannot do fcntl on a file located on an TMPFS filesystem");
+	}
+
 	/* set the expected errnos... */
 	TEST_EXP_ENOS(exp_enos);
 
Index: testcases/kernel/syscalls/fcntl/fcntl25.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl25.c,v
retrieving revision 1.9
diff -u -r1.9 fcntl25.c
--- testcases/kernel/syscalls/fcntl/fcntl25.c	23 Mar 2009 13:35:41 -0000	1.9
+++ testcases/kernel/syscalls/fcntl/fcntl25.c	29 Jul 2009 14:49:08 -0000
@@ -132,6 +132,14 @@
 			 "Cannot do fcntl on a file located on an NFS filesystem");
 	}
 
+	/*
+	 * check if the current filesystem is tmpfs
+	 */
+	if (tst_is_cwd_tmpfs()) {
+		tst_brkm(TCONF, cleanup,
+			 "Cannot do fcntl on a file located on an TMPFS filesystem");
+	}
+
 	/* set the expected errnos... */
 	TEST_EXP_ENOS(exp_enos);
 
Index: testcases/kernel/syscalls/fcntl/fcntl26.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl26.c,v
retrieving revision 1.9
diff -u -r1.9 fcntl26.c
--- testcases/kernel/syscalls/fcntl/fcntl26.c	23 Mar 2009 13:35:41 -0000	1.9
+++ testcases/kernel/syscalls/fcntl/fcntl26.c	29 Jul 2009 14:49:08 -0000
@@ -132,6 +132,14 @@
 			 "Cannot do fcntl on a file located on an NFS filesystem");
 	}
 
+	/*
+	 * check if the current filesystem is tmpfs
+	 */
+	if (tst_is_cwd_tmpfs()) {
+		tst_brkm(TCONF, cleanup,
+			 "Cannot do fcntl on a file located on an TMPFS filesystem");
+	}
+
 	/* set the expected errnos... */
 	TEST_EXP_ENOS(exp_enos);
 

[-- Attachment #3: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #4: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] fcntl24,25,26 fail when run on tmpfs

[Michal Simek]

Hi Matt,
> Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
> the host is running on tmpfs. The reason being that, as documented here
> http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
> cannot work on tmpfs.
>   
I tested it and works. The same issue is for RAMFS. But for this fs in
necessary to create
tst_is_cwd_ramfs function. Maybe worth to add together
tst_is_cwd_tmpfs.c and tst_cwd_has_free.c too.

Regards,
Michal

>   
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> ------------------------------------------------------------------------
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] fcntl24,25,26 fail when run on tmpfs

[Matt Fleming]

On Thu, Jul 30, 2009 at 12:59:17PM +0200, Michal Simek wrote:
> Hi Matt,
> > Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
> > the host is running on tmpfs. The reason being that, as documented here
> > http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
> > cannot work on tmpfs.
> >   
> I tested it and works. The same issue is for RAMFS. But for this fs in
> necessary to create
> tst_is_cwd_ramfs function. Maybe worth to add together
> tst_is_cwd_tmpfs.c and tst_cwd_has_free.c too.
>

Thanks for testing. Yes, the same issue will affect ramfs too.

I'm not quite sure what sure why you're saying tst_cwd_has_free is
needed?

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] fcntl24,25,26 fail when run on tmpfs

[Michal Simek]

Matt Fleming wrote:
> On Thu, Jul 30, 2009 at 12:59:17PM +0200, Michal Simek wrote:
>   
>> Hi Matt,
>>     
>>> Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
>>> the host is running on tmpfs. The reason being that, as documented here
>>> http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
>>> cannot work on tmpfs.
>>>   
>>>       
>> I tested it and works. The same issue is for RAMFS. But for this fs in
>> necessary to create
>> tst_is_cwd_ramfs function. Maybe worth to add together
>> tst_is_cwd_tmpfs.c and tst_cwd_has_free.c too.
>>
>>     
>
> Thanks for testing. Yes, the same issue will affect ramfs too.
>
> I'm not quite sure what sure why you're saying tst_cwd_has_free is
> needed?
>   
I meant that will be worth to create new one file instead of tree.
I don't know call it tst_cwd_tests.c and add there content of 

tst_is_cwd_tmpfs.c and tst_cwd_has_free.c + testing function for ramfs.

Cheers,
Michal

-- 
Michal Simek, Ing. (M.Eng)
PetaLogix - Linux Solutions for a Reconfigurable World
w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] fcntl24,25,26 fail when run on tmpfs

[Subrata Modak]

On Thu, 2009-07-30 at 12:59 +0200, Michal Simek wrote: 
> Hi Matt,
> > Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
> > the host is running on tmpfs. The reason being that, as documented here
> > http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
> > cannot work on tmpfs.

Thanks for this patch, except that it does not have a Signed-off-by:
Matt Fleming <matt@console-pimps.org>, though i have added the same in
CVS log message:
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl24.c?view=log,
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl25.c?view=log,
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl26.c?view=log,

> >   
> I tested it and works. The same issue is for RAMFS. But for this fs in
> necessary to create
> tst_is_cwd_ramfs function. Maybe worth to add together
> tst_is_cwd_tmpfs.c and tst_cwd_has_free.c too.

Thanks Michal for testing this.

Regards--
Subrata

> 
> Regards,
> Michal
> 
> >   
> > ------------------------------------------------------------------------
> >
> > ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> > trial. Simplify your report design, integration and deployment - and focus on 
> > what you do best, core application coding. Discover what's new with 
> > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> > ------------------------------------------------------------------------
> >
> > _______________________________________________
> > Ltp-list mailing list
> > Ltp-list@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/ltp-list
> 
> 


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] fcntl24,25,26 fail when run on tmpfs

[Matt Fleming]

On Mon, Aug 03, 2009 at 04:49:55PM +0530, Subrata Modak wrote:
> On Thu, 2009-07-30 at 12:59 +0200, Michal Simek wrote: 
> > Hi Matt,
> > > Attached is a patch to skip testcases fcntl24, fcntl25 and fcntl26 if
> > > the host is running on tmpfs. The reason being that, as documented here
> > > http://bugzilla.kernel.org/show_bug.cgi?id=13626, F_SETLEASE and F_WRLCK
> > > cannot work on tmpfs.
> 
> Thanks for this patch, except that it does not have a Signed-off-by:
> Matt Fleming <matt@console-pimps.org>, though i have added the same in
> CVS log message:
> http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl24.c?view=log,
> http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl25.c?view=log,
> http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/fcntl/fcntl26.c?view=log,
> 

Oops, sorry I forgot the SOB line. Thanks for applying them!


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list