public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Darren Hart <dvhltc@us.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: ltp-list <ltp-list@lists.sf.net>,
	Gregory Haskins <ghaskins@novell.com>,
	Clark Williams <clark.williams@gmail.com>,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [LTP] LTP RT Tests (Cyclic, rt-migrate, etc)
Date: Thu, 30 Jul 2009 12:49:56 -0700	[thread overview]
Message-ID: <4A71F964.1060507@us.ibm.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0907301440460.21267@gandalf.stny.rr.com>

Steven Rostedt wrote:
> 
> On Thu, 30 Jul 2009, Subrata Modak wrote:
>>> Yup.  This is different than prio-wake.  Prio-wake creates some number 
>>> of threads of varying priorities and puts them to sleep on 
>>> pthread_cond_wait and then wakes them with pthread_cond_broadcast, then 
>>> tests that the threads were woken in priority order.  Fails on 
>>> kernels/glibc without requeue pi support as a FUTEX_WAKE(all) was used 
>>> for PI mutexes.
>>>
>>> So to include this in the ltp/restcases/realtime suite, the test should 
>>> make use of the librttest.c and libstats.c apis, standardized argument 
>>> parsing, buffered logging mechanism, and standardized output formatting. 
>>>   I can't get to that for a little while myself, but can assist if you 
>>> have any questions.  Alternatively we can wait a little while, and 
>>> perhaps someone on my team will be able to help merge it with the 
>>> realtime test infrastructure in LTP.
>> That should be fine.
>>
> 
> Note,
> 
> Please take the following code:
> 
>  http://rostedt.homelinux.com/code/rt-migrate-test.c
> 
> Because I got rid of the old logdev writes (ifdef out) and replaced it 
> with ftrace. It tries to write to ftrace if possible, but if ftrace is not 
> configured, it should just ignore it.

Just to be clear, Steven you want us to modify this test case so that it 
uses the librttest facilities, including those for standardized argument 
parsing, buffered out, and thread creation, then commit this to the 
repository?  I don't feel it should go in without those changes.  We've 
expended a lot of effort making the tests in ltp/realtime be consistent 
in those areas (they all use some common command line arguments and 
coding styles).  This ensures that they can be easily maintained along 
with the other tests in the suite and that users can know what to expect 
from the test in terms of output, etc.

Thanks,

-- 
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-07-30 19:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1224509719.5152.116.camel@subratamodak.linux.ibm.com>
     [not found] ` <1224840077.5270.69.camel@subratamodak.linux.ibm.com>
     [not found]   ` <alpine.DEB.1.10.0810240749470.25677@gandalf.stny.rr.com>
     [not found]     ` <1229093480.5171.60.camel@subratamodak.linux.ibm.com>
     [not found]       ` <alpine.DEB.1.10.0812121533350.29763@gandalf.stny.rr.com>
     [not found]         ` <1229347938.5353.8.camel@subratamodak.linux.ibm.com>
     [not found]           ` <alpine.DEB.1.10.0812150851290.18692@gandalf.stny.rr.com>
     [not found]             ` <1245768486.4860.53.camel@subratamodak.linux.ibm.com>
     [not found]               ` <alpine.DEB.2.00.0907061024200.8813@gandalf.stny.rr.com>
2009-07-06 14:31                 ` [LTP] LTP RT Tests (Cyclic, rt-migrate, etc) Subrata Modak
2009-07-08 18:13                   ` Subrata Modak
2009-07-10 16:30                     ` Sripathi Kodi
2009-07-10 16:47                       ` Subrata Modak
2009-07-10 18:28                         ` Darren Hart
2009-07-20 14:43                           ` Steven Rostedt
2009-07-20 14:52                             ` Gregory Haskins
2009-07-20 17:03                             ` Darren Hart
2009-07-30 18:28                               ` Subrata Modak
2009-07-30 18:42                                 ` Steven Rostedt
2009-07-30 19:49                                   ` Darren Hart [this message]
2009-07-30 20:03                                     ` Steven Rostedt
2009-07-30 20:10                                       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A71F964.1060507@us.ibm.com \
    --to=dvhltc@us.ibm.com \
    --cc=clark.williams@gmail.com \
    --cc=ghaskins@novell.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=ltp-list@lists.sf.net \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox