Re: [LTP] [PATCH] Fix failure of the utimensat01 test

[Wang Yong <wangyong2009@cn.fujitsu.com>]

Garrett Cooper wrote as:
> On Wed, Jul 29, 2009 at 11:31 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
>   
>> Garrett Cooper wrote as:
>>     
>>> On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com>
>>> wrote:
>>>
>>>       
>>>> The error handling for "RW" opt of run_test brought about error results.
>>>> This patch fixed that.
>>>>
>>>> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
>>>>
>>>> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>>  2009-07-28 16:23:39.000000000 +0800
>>>> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>>  2009-07-28 17:32:26.000000000 +0800
>>>> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
>>>>  echo
>>>>
>>>>         
>>> [...]
>>>
>>> Don't these changes actually conflict with the testcase's purpose,
>>> given the messages echoed placed directly above the commands?
>>> Thanks,
>>> -Garrett
>>>
>>>
>>>       
>> Hi Garrett,
>>
>> This patch doesn't change the testcase's purpose.
>> And the test results prove it.
>>     
>
> Wang,
>     You're changing everything to RW -- how is that not contradicting
> the phrase `Testing read-only file'?
>     Just because things fail doesn't necessarily mean that the entire
> intent is incorrect. Let's make sure not to lose sight of that point
> :).
> Thanks,
> -Garrett
>
>   

Hi,

Thanks for your advice.
I did change the testcase's purpose when  I changed the "RW" opt.
And I will make patch in accordance with
the principle of  not changing the testcase's purpose.

Thanks,
-Wang Yong
>
>   



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list