* [LTP] [PATCH] Fix failure of the utimensat01 test
@ 2009-07-30 1:00 Wang Yong
0 siblings, 0 replies; 7+ messages in thread
From: Wang Yong @ 2009-07-30 1:00 UTC (permalink / raw)
To: LTP
The error handling for "RW" opt of run_test brought about error results.
This patch fixed that.
Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
--- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 15:44:13.000000000 +0800
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
echo
echo "***** Testing times==NULL case *****"
-run_test "" 400 "" "" SUCCESS y y
+run_test -W "" 400 "" "" SUCCESS y y
echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test "" 400 "" "0 n 0 n" SUCCESS y y
+run_test -W "" 400 "" "0 n 0 n" SUCCESS y y
echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 o 0 o" SUCCESS n n
+run_test -W "" 400 "" "0 o 0 o" SUCCESS n n
echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 n 0 o" SUCCESS y n
+run_test -W "" 400 "" "0 n 0 o" SUCCESS y n
echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test "" 400 "" "0 o 0 n" SUCCESS n y
+run_test -W "" 400 "" "0 o 0 n" SUCCESS n y
echo "***** Testing times=={ x, y } case *****"
-run_test "" 400 "" "1 1 1 1" SUCCESS y y
+run_test -W "" 400 "" "1 1 1 1" SUCCESS y y
echo "============================================================"
@@ -284,22 +284,22 @@ echo "Testing read-only file, not owned
echo
echo "***** Testing times==NULL case *****"
-run_test root 400 "" "" EACCES
+run_test -RW root 400 "" "" EACCES
echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test root 400 "" "0 n 0 n" EACCES
+run_test -RW root 400 "" "0 n 0 n" EACCES
echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test root 400 "" "0 o 0 o" SUCCESS n n
+run_test -RW root 400 "" "0 o 0 o" SUCCESS n n
echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test root 400 "" "0 n 0 o" EPERM
+run_test -RW root 400 "" "0 n 0 o" EPERM
echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test root 400 "" "0 o 0 n" EPERM
+run_test -RW root 400 "" "0 o 0 n" EPERM
echo "***** Testing times=={ x, y } case *****"
-run_test root 400 "" "1 1 1 1" EPERM
+run_test -RW root 400 "" "1 1 1 1" EPERM
echo "============================================================"
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* [LTP] [PATCH] Fix failure of the utimensat01 test
@ 2009-07-30 1:33 Wang Yong
2009-07-30 3:19 ` Garrett Cooper
0 siblings, 1 reply; 7+ messages in thread
From: Wang Yong @ 2009-07-30 1:33 UTC (permalink / raw)
To: LTP
The error handling for "RW" opt of run_test brought about error results.
This patch fixed that.
Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
--- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800
+++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800
@@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
echo
echo "***** Testing times==NULL case *****"
-run_test "" 400 "" "" SUCCESS y y
+run_test -W "" 400 "" "" SUCCESS y y
echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test "" 400 "" "0 n 0 n" SUCCESS y y
+run_test -W "" 400 "" "0 n 0 n" SUCCESS y y
echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 o 0 o" SUCCESS n n
+run_test -W "" 400 "" "0 o 0 o" SUCCESS n n
echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test "" 400 "" "0 n 0 o" SUCCESS y n
+run_test -W "" 400 "" "0 n 0 o" SUCCESS y n
echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test "" 400 "" "0 o 0 n" SUCCESS n y
+run_test -W "" 400 "" "0 o 0 n" SUCCESS n y
echo "***** Testing times=={ x, y } case *****"
-run_test "" 400 "" "1 1 1 1" SUCCESS y y
+run_test -W "" 400 "" "1 1 1 1" SUCCESS y y
echo "============================================================"
@@ -284,22 +284,22 @@ echo "Testing read-only file, not owned
echo
echo "***** Testing times==NULL case *****"
-run_test root 400 "" "" EACCES
+run_test -RW root 400 "" "" EACCES
echo "***** Testing times=={ UTIME_NOW, UTIME_NOW } case *****"
-run_test root 400 "" "0 n 0 n" EACCES
+run_test -RW root 400 "" "0 n 0 n" EACCES
echo "***** Testing times=={ UTIME_OMIT, UTIME_OMIT } case *****"
-run_test root 400 "" "0 o 0 o" SUCCESS n n
+run_test -RW root 400 "" "0 o 0 o" SUCCESS n n
echo "***** Testing times=={ UTIME_NOW, UTIME_OMIT } case *****"
-run_test root 400 "" "0 n 0 o" EPERM
+run_test -RW root 400 "" "0 n 0 o" EPERM
echo "***** Testing times=={ UTIME_OMIT, UTIME_NOW } case *****"
-run_test root 400 "" "0 o 0 n" EPERM
+run_test -RW root 400 "" "0 o 0 n" EPERM
echo "***** Testing times=={ x, y } case *****"
-run_test root 400 "" "1 1 1 1" EPERM
+run_test -RW root 400 "" "1 1 1 1" EPERM
echo "============================================================"
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] Fix failure of the utimensat01 test
2009-07-30 1:33 [LTP] [PATCH] Fix failure of the utimensat01 test Wang Yong
@ 2009-07-30 3:19 ` Garrett Cooper
2009-07-30 6:31 ` Wang Yong
0 siblings, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2009-07-30 3:19 UTC (permalink / raw)
To: Wang Yong; +Cc: LTP
On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
> The error handling for "RW" opt of run_test brought about error results.
> This patch fixed that.
>
> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
>
> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800
> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800
> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
> echo
[...]
Don't these changes actually conflict with the testcase's purpose,
given the messages echoed placed directly above the commands?
Thanks,
-Garrett
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] Fix failure of the utimensat01 test
2009-07-30 3:19 ` Garrett Cooper
@ 2009-07-30 6:31 ` Wang Yong
2009-07-30 18:29 ` Subrata Modak
2009-07-30 19:24 ` Garrett Cooper
0 siblings, 2 replies; 7+ messages in thread
From: Wang Yong @ 2009-07-30 6:31 UTC (permalink / raw)
To: Garrett Cooper; +Cc: LTP
Garrett Cooper wrote as:
> On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
>
>> The error handling for "RW" opt of run_test brought about error results.
>> This patch fixed that.
>>
>> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
>>
>> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800
>> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800
>> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
>> echo
>>
>
> [...]
>
> Don't these changes actually conflict with the testcase's purpose,
> given the messages echoed placed directly above the commands?
> Thanks,
> -Garrett
>
>
Hi Garrett,
This patch doesn't change the testcase's purpose.
And the test results prove it.
Best regards,
Wang Yong
>
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] Fix failure of the utimensat01 test
2009-07-30 6:31 ` Wang Yong
@ 2009-07-30 18:29 ` Subrata Modak
2009-07-30 19:24 ` Garrett Cooper
1 sibling, 0 replies; 7+ messages in thread
From: Subrata Modak @ 2009-07-30 18:29 UTC (permalink / raw)
To: Wang Yong; +Cc: LTP
On Thu, 2009-07-30 at 14:31 +0800, Wang Yong wrote:
> Garrett Cooper wrote as:
> > On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
> >
> >> The error handling for "RW" opt of run_test brought about error results.
> >> This patch fixed that.
> >>
> >> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
> >>
> >> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> >> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
> >> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 16:23:39.000000000 +0800
> >> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh 2009-07-28 17:32:26.000000000 +0800
> >> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
> >> echo
> >>
> >
> > [...]
> >
> > Don't these changes actually conflict with the testcase's purpose,
> > given the messages echoed placed directly above the commands?
> > Thanks,
> > -Garrett
> >
> >
> Hi Garrett,
>
> This patch doesn't change the testcase's purpose.
> And the test results prove it.
However, a much broader explanation of the Patch and itś purpose would
indeed help a great deal.
Regards--
Subrata
>
> Best regards,
> Wang Yong
>
> >
> >
>
>
>
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] Fix failure of the utimensat01 test
2009-07-30 6:31 ` Wang Yong
2009-07-30 18:29 ` Subrata Modak
@ 2009-07-30 19:24 ` Garrett Cooper
2009-08-04 0:44 ` Wang Yong
1 sibling, 1 reply; 7+ messages in thread
From: Garrett Cooper @ 2009-07-30 19:24 UTC (permalink / raw)
To: Wang Yong; +Cc: LTP
On Wed, Jul 29, 2009 at 11:31 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
>
> Garrett Cooper wrote as:
>>
>> On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com>
>> wrote:
>>
>>>
>>> The error handling for "RW" opt of run_test brought about error results.
>>> This patch fixed that.
>>>
>>> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
>>>
>>> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>> 2009-07-28 16:23:39.000000000 +0800
>>> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>> 2009-07-28 17:32:26.000000000 +0800
>>> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
>>> echo
>>>
>>
>> [...]
>>
>> Don't these changes actually conflict with the testcase's purpose,
>> given the messages echoed placed directly above the commands?
>> Thanks,
>> -Garrett
>>
>>
>
> Hi Garrett,
>
> This patch doesn't change the testcase's purpose.
> And the test results prove it.
Wang,
You're changing everything to RW -- how is that not contradicting
the phrase `Testing read-only file'?
Just because things fail doesn't necessarily mean that the entire
intent is incorrect. Let's make sure not to lose sight of that point
:).
Thanks,
-Garrett
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [LTP] [PATCH] Fix failure of the utimensat01 test
2009-07-30 19:24 ` Garrett Cooper
@ 2009-08-04 0:44 ` Wang Yong
0 siblings, 0 replies; 7+ messages in thread
From: Wang Yong @ 2009-08-04 0:44 UTC (permalink / raw)
To: Garrett Cooper; +Cc: LTP
Garrett Cooper wrote as:
> On Wed, Jul 29, 2009 at 11:31 PM, Wang Yong<wangyong2009@cn.fujitsu.com> wrote:
>
>> Garrett Cooper wrote as:
>>
>>> On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong<wangyong2009@cn.fujitsu.com>
>>> wrote:
>>>
>>>
>>>> The error handling for "RW" opt of run_test brought about error results.
>>>> This patch fixed that.
>>>>
>>>> Signed-off-by: WangYong <wangyong2009@cn.fujitsu.com>
>>>>
>>>> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> 2009-07-28 16:23:39.000000000 +0800
>>>> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh
>>>> 2009-07-28 17:32:26.000000000 +0800
>>>> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s
>>>> echo
>>>>
>>>>
>>> [...]
>>>
>>> Don't these changes actually conflict with the testcase's purpose,
>>> given the messages echoed placed directly above the commands?
>>> Thanks,
>>> -Garrett
>>>
>>>
>>>
>> Hi Garrett,
>>
>> This patch doesn't change the testcase's purpose.
>> And the test results prove it.
>>
>
> Wang,
> You're changing everything to RW -- how is that not contradicting
> the phrase `Testing read-only file'?
> Just because things fail doesn't necessarily mean that the entire
> intent is incorrect. Let's make sure not to lose sight of that point
> :).
> Thanks,
> -Garrett
>
>
Hi,
Thanks for your advice.
I did change the testcase's purpose when I changed the "RW" opt.
And I will make patch in accordance with
the principle of not changing the testcase's purpose.
Thanks,
-Wang Yong
>
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-08-04 0:43 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-30 1:33 [LTP] [PATCH] Fix failure of the utimensat01 test Wang Yong
2009-07-30 3:19 ` Garrett Cooper
2009-07-30 6:31 ` Wang Yong
2009-07-30 18:29 ` Subrata Modak
2009-07-30 19:24 ` Garrett Cooper
2009-08-04 0:44 ` Wang Yong
-- strict thread matches above, loose matches on Subject: below --
2009-07-30 1:00 Wang Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox