From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-1.v28.ch3.sourceforge.com ([172.29.28.121] helo=mx.sourceforge.net) by h25xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1MY87m-0003wP-QX for ltp-list@lists.sourceforge.net; Tue, 04 Aug 2009 00:43:30 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by 29vjzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1MY87f-0002TW-EL for ltp-list@lists.sourceforge.net; Tue, 04 Aug 2009 00:43:30 +0000 Message-ID: <4A77846A.3030203@cn.fujitsu.com> Date: Tue, 04 Aug 2009 08:44:26 +0800 From: Wang Yong MIME-Version: 1.0 References: <4A70F86E.50608@cn.fujitsu.com> <364299f40907292019r494348dt1e895f0c180f3f58@mail.gmail.com> <4A713E40.2010000@cn.fujitsu.com> <364299f40907301224o4007a6bbnadd176f67d87bf2@mail.gmail.com> In-Reply-To: <364299f40907301224o4007a6bbnadd176f67d87bf2@mail.gmail.com> Subject: Re: [LTP] [PATCH] Fix failure of the utimensat01 test List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: Garrett Cooper Cc: LTP Garrett Cooper wrote as: > On Wed, Jul 29, 2009 at 11:31 PM, Wang Yong wrote: > >> Garrett Cooper wrote as: >> >>> On Wed, Jul 29, 2009 at 6:33 PM, Wang Yong >>> wrote: >>> >>> >>>> The error handling for "RW" opt of run_test brought about error results. >>>> This patch fixed that. >>>> >>>> Signed-off-by: WangYong >>>> >>>> diff -Nurp a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh >>>> b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh >>>> --- a/testcases/kernel/syscalls/utimensat/utimensat_tests.sh >>>> 2009-07-28 16:23:39.000000000 +0800 >>>> +++ b/testcases/kernel/syscalls/utimensat/utimensat_tests.sh >>>> 2009-07-28 17:32:26.000000000 +0800 >>>> @@ -260,22 +260,22 @@ echo "Testing read-only file, owned by s >>>> echo >>>> >>>> >>> [...] >>> >>> Don't these changes actually conflict with the testcase's purpose, >>> given the messages echoed placed directly above the commands? >>> Thanks, >>> -Garrett >>> >>> >>> >> Hi Garrett, >> >> This patch doesn't change the testcase's purpose. >> And the test results prove it. >> > > Wang, > You're changing everything to RW -- how is that not contradicting > the phrase `Testing read-only file'? > Just because things fail doesn't necessarily mean that the entire > intent is incorrect. Let's make sure not to lose sight of that point > :). > Thanks, > -Garrett > > Hi, Thanks for your advice. I did change the testcase's purpose when I changed the "RW" opt. And I will make patch in accordance with the principle of not changing the testcase's purpose. Thanks, -Wang Yong > > ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list