public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Paul Larson <paul.larson@canonical.com>
To: Subrata Modak <subrata@linux.vnet.ibm.com>
Cc: LTP Mailing List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 05/05] Add the necessary Interface and Option through "runltp"
Date: Tue, 11 Aug 2009 13:02:15 -0500	[thread overview]
Message-ID: <4A81B227.7020500@canonical.com> (raw)
In-Reply-To: <20090811173101.7074.31798.sendpatchset@subratamodak.linux.ibm.com>

Subrata Modak wrote:
...
> +	-F LOOPS,PERCENTAGE Induce PERCENTAGE Fault in the Kernel Subsystems, and, run each test for LOOPS loop

I haven't had time for an exhaustive review, but here are a few
questions/comments I had:

1. Why introduce yet another looping mechanism within LTP when we
already have one?  Is there an advantage that you see to doing it this
way, rather than just having an additional option that calls the script
to generate this additional random fault injection?

2. Would be good to push the check for /debug being mounted down into
one of the other scripts rather than in runltp.  runltp is already
hideously bloated and this would make it more useful when running
standalone.

3. would be great if there were some way to tag the results to say when
a fault was or was not in the process of being generated.  That is,
perhaps, not possible at this time though.

4. more granularity possible with the fault injections to specify the
type of faults, or optionally, the behaviour you have here?

Thanks,
Paul Larson


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-08-11 18:02 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11 17:29 [LTP] [PATCH 00/05] Integration of "Fault Injection Framework" into LTP Subrata Modak
2009-08-11 17:30 ` [LTP] [PATCH 01/05] Provide all necessary information through ltp/README Subrata Modak
2009-08-11 17:30 ` [LTP] [PATCH 02/05] Add Script which would actually do the job of injecting faults Subrata Modak
2009-08-12  8:45   ` Garrett Cooper
2009-08-12 11:20     ` Subrata Modak
2009-08-11 17:30 ` [LTP] [PATCH 03/05] Add Script so the kernel is restored back to its original pristine form Subrata Modak
2009-08-11 17:30 ` [LTP] [PATCH 04/05] Add Script which will be at the heart of this infrastructure Subrata Modak
2009-08-12  8:42   ` Garrett Cooper
2009-08-12 11:21     ` Subrata Modak
2009-08-13  7:11       ` Mike Frysinger
2009-08-11 17:31 ` [LTP] [PATCH 05/05] Add the necessary Interface and Option through "runltp" Subrata Modak
2009-08-11 18:02   ` Paul Larson [this message]
     [not found]   ` <4A81B1A0.5050708@ubuntu.com>
2009-08-12 11:21     ` Subrata Modak
2009-08-13  7:13   ` Mike Frysinger
2009-08-11 17:31 ` [LTP] [RESULTS] Results of test run for "Fault Injection Framework" Subrata Modak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A81B227.7020500@canonical.com \
    --to=paul.larson@canonical.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=subrata@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox