From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.123] helo=mx.sourceforge.net) by 235xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1Mh33D-0004py-2w for ltp-list@lists.sourceforge.net; Fri, 28 Aug 2009 15:07:39 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by 3b2kzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1Mh336-0006cm-Qx for ltp-list@lists.sourceforge.net; Fri, 28 Aug 2009 15:07:39 +0000 Message-ID: <4A97F2A6.1060803@redhat.com> Date: Fri, 28 Aug 2009 11:07:18 -0400 From: Mike Gahagan MIME-Version: 1.0 References: <4A92DCAE.5060102@redhat.com> <1251194293.5534.24.camel@subratamodak.linux.ibm.com> <4A955C57.7020502@redhat.com> <1251368398.4993.18.camel@subratamodak.linux.ibm.com> In-Reply-To: <1251368398.4993.18.camel@subratamodak.linux.ibm.com> Subject: Re: [LTP] Bug in memory controller test - memctl test #4 - PATCH repost List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: subrata@linux.vnet.ibm.com Cc: ltp-list@lists.sourceforge.net On 08/27/2009 06:19 AM, Subrata Modak wrote: > Hi, > > On Wed, 2009-08-26 at 12:01 -0400, Mike Gahagan wrote: >> On 08/25/2009 05:58 AM, Subrata Modak wrote: >>> On Mon, 2009-08-24 at 14:32 -0400, Mike Gahagan wrote: >>>> When running the Memory Controller test # 4, I'm seeing this behavior below. >>>> >>>> TEST 4: MEMORY CONTROLLER TESTING >>>> RUNNING SETUP..... >>>> TEST STARTED: Please avoid using system while this test executes >>>> /mnt/tests/kernel/distribution/ltp/20090731/ltp-full-20090731/testcases/bin/run_memctl_test.sh: >>>> line 327: [: 62955520: unary operator expected >>>> TINFO Memory Resource Controller: stat check test fails in first run >>>> /mnt/tests/kernel/distribution/ltp/20090731/ltp-full-20090731/testcases/bin/run_memctl_test.sh: >>>> line 364: [: 78704640: unary operator expected >>>> TFAIL Memory Resource Controller: stat check test FAILED >>>> *** infinite loop here, script exists memctl_test01 remains running *** >>>> ^Cincrementing stop >>>> >>>> The bash error is due to the 'grep -w "active"' not matching anything so >>>> one of the variables isn't getting set like it is supposed to. I believe >>>> the test was written with an old version of the memory controller what >>>> put a field called memory.stat.active in the file memory.stat. The >>> >>> Correct. Somebody needs to revisit these tests, as the ABIs has changed. > > Would be able to spend some time here ? > Sure, I would be glad to. So far this was the only issue I have found (or the only really obvious one at least). I plan on picking up and running the recently checked in new tests as well, probably in the next week or so. >>> Thanks for pointing that out. However, your patch has the following >>> problem: >>> >>> 1) Missing Signed-off-by: >>> 2) missing header for unified diff at line 3 of patch >>> patching file testcases/kernel/controllers/memctl/run_memctl_test.sh >>> >>> Please look into them when you send a patch next time ;-) >>> >>> Regards-- >>> Subrata >>> >>>> current memory controller I am testing appears to have replaced this >>>> field with "rss". There are fields showing anonymous and file backed >>>> pages in memory.stat, but I don't think they are ever going to match the >>>> memory.usage.in.bytes the test is looking for. Rss always matches and I >>>> believe that is what we should update the check in the test to look for. >>>> The attached patch fixes test #4 to compare memory.usage.in.bytes with rss. >>>> ------------------------------------------------------------------------------ >> >> Hello, >> >> Here is a resubmission of my memctl test patch. It should clear up the >> issues noted above. No functional change from the previous patch. >> >> Signed-off-by: Mike Gahagan > > Thanks. I already merged your patch. > Thank you ! ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list