public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Suzuki Poulose <suzuki@in.ibm.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] LTP : Fix connectors event_generator program : gen_fork
Date: Wed, 09 Sep 2009 13:11:55 +0800	[thread overview]
Message-ID: <4AA7391B.4020804@cn.fujitsu.com> (raw)
In-Reply-To: <4AA67D12.5010602@in.ibm.com>

Suzuki Poulose wrote:
> Hi,
> 
> There is a testcase issue in the event_generator code. The gen_fork() is
> called to generate the fork event.
> 
> The child process prints the following message:
> 
> static inline void gen_fork(void)
> {
>         pid_t pid;
>         int status;
> 
>         pid = fork();
>         if (pid == 0) {
>                 printf("fork parent: %d, child: %d\n", getppid(),
> getpid());
>                 exit(0);
>         } else if (pid < 0) {
>                 fprintf(stderr, "fork() failed\n");
>                 exit(1);
>         }
> }
> 
> Now the parent process just exits after this call. So, if the child
> doesn't get to run before parent exits, the child will see the ppid as
> 1, that of INIT and this contradicts the actual data. Hence the test fails.
> 
> Attached patch fixes the issue. I have verified the same. Please apply.
> 

Thanks for fixing it.

Acked-by: Li Zefan <lizf@cn.fujitsu.com>

But you forgot to add your Signed-off-by in the patch. ;)


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2009-09-09  5:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-08 15:49 [LTP] LTP : Fix connectors event_generator program : gen_fork Suzuki Poulose
2009-09-09  5:11 ` Li Zefan [this message]
2009-09-09  5:18   ` Suzuki Poulose
2009-09-09  6:49     ` Subrata Modak
2009-09-09 21:31       ` Garrett Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AA7391B.4020804@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=suzuki@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox