[LTP] [PATCH] build rule for t0 in open_posix_testsuite

[LTP] [PATCH] build rule for t0 in open_posix_testsuite

[Seiichi Ikarashi]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

Hi,

I propose two patches (two patterns of fix) for an issue of open_posix_testsuite.
I hope either one of them (or more better one someone will write) is committed.

You need to do three steps below in order to run execute.sh of open_posix_testsuite:
 1) make build-tests
 2) cc -O2 -o t0 t0.c
 3) ./execute.sh

I think it's better to include step 2 into step 1 or 3 for convenience.
So I wrote two different patches for these cases.

Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>

Regards,

[-- Attachment #2: into1.patch --]
[-- Type: text/x-patch, Size: 1330 bytes --]

Index: ltp/testcases/open_posix_testsuite/Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/open_posix_testsuite/Makefile,v
retrieving revision 1.25
diff -u -r1.25 Makefile
--- ltp/testcases/open_posix_testsuite/Makefile	23 Oct 2008 07:36:28 -0000	1.25
+++ ltp/testcases/open_posix_testsuite/Makefile	13 Sep 2009 23:58:41 -0000
@@ -76,7 +76,7 @@
 # Rule to run a build test
 # If the .o doesn't export main, then we don't need to link
 .PRECIOUS: %.test
-%.test: %.o
+%.test: %.o $(top_builddir)/t0
 	@COMPLOG=$(LOGFILE).$$$$; \
 	[ -f $< ] || exit 0; \
 	{ nm -g $< | grep -q ' T main\| D main'; } || \
@@ -96,7 +96,7 @@
 # Rule to run an executable test
 # If it is only a build test, then the binary exist, so we don't need to run
 .PHONY: %.run-test
-%.run-test: %.test $(top_builddir)/t0 $(top_builddir)/t0.val
+%.run-test: %.test $(top_builddir)/t0.val
 	@COMPLOG=$(LOGFILE).$$$$; \
 	[ -f $< ] || exit 0; \
 	$(TIMEOUT) $< > $$COMPLOG 2>&1; \
@@ -144,7 +144,7 @@
 $(top_builddir)/t0.val: $(top_builddir)/t0
 	echo `$(top_builddir)/t0 0; echo $$?` > $(top_builddir)/t0.val
 	
-%.run-test: %.sh $(top_builddir)/t0 $(top_builddir)/t0.val
+%.run-test: %.sh $(top_builddir)/t0.val
 	@COMPLOG=$(LOGFILE).$$$$; \
 	chmod +x $<; \
 	$(TIMEOUT) $< > $$COMPLOG 2>&1; \

[-- Attachment #3: into3.patch --]
[-- Type: text/x-patch, Size: 777 bytes --]

Index: ltp/testcases/open_posix_testsuite/execute.sh
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/open_posix_testsuite/execute.sh,v
retrieving revision 1.3
diff -u -r1.3 execute.sh
--- ltp/testcases/open_posix_testsuite/execute.sh	4 Aug 2009 10:50:07 -0000	1.3
+++ ltp/testcases/open_posix_testsuite/execute.sh	13 Sep 2009 23:58:41 -0000
@@ -166,8 +166,11 @@
 # Maximum five minutes waiting time period to execute a test. If it exceeds, the test case will go into the 'HUNG' category.
 TIMEOUT_VAL=300
 
-# if gcc available then remove the below line comment else put the t0 in posixtestsuite directory.
-#gcc -o t0 t0.c
+if [ ! -x t0 ]
+then
+      cc -O2 -o t0 t0.c
+fi
+
 ./t0 0 > /dev/null 2>&1
 TIMEVAL_RET=$?
 

[-- Attachment #4: Type: text/plain, Size: 355 bytes --]

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july

[-- Attachment #5: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] build rule for t0 in open_posix_testsuite

[Subrata Modak]

On Mon, 2009-09-14 at 09:05 +0900, Seiichi Ikarashi wrote: 
> Hi,
> 
> I propose two patches (two patterns of fix) for an issue of open_posix_testsuite.
> I hope either one of them (or more better one someone will write) is committed.
> 
> You need to do three steps below in order to run execute.sh of open_posix_testsuite:
>  1) make build-tests
>  2) cc -O2 -o t0 t0.c

I prefer the first patch, as, all build items should be combined and
completed before any actual execution.

Regards--
Subrata

> 3) ./execute.sh
> 
> I think it's better to include step 2 into step 1 or 3 for convenience.
> So I wrote two different patches for these cases.
> 
> Signed-off-by: Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>
> 
> Regards,
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
> trial. Simplify your report design, integration and deployment - and focus on 
> what you do best, core application coding. Discover what's new with 
> Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list