Re: [LTP] [PATCH 1/3] fsstress: fix memory leaks

[Vagin Andrew <avagin@gmail.com>]

On 09/27/2009 01:29 AM, Garrett Cooper wrote:

Thanks for your comments, I resent all patches.

> On Sat, Sep 26, 2009 at 4:34 AM, Andrew Vagin<avagin@gmail.com>  wrote:
>    
>> ==11424== 156 bytes in 1 blocks are definitely lost in loss record 2 of 2
>> ==11424==    at 0x4A0763E: malloc (vg_replace_malloc.c:207)
>> ==11424==    by 0x402E4C: make_freq_table (fsstress.c:986)
>> ==11424==    by 0x401C26: main (fsstress.c:410)
>>
>> make_freq_table is executed on each iterations, but freq_table is not
>> changed during test, so this patch moves it from the loop
>> ---
>>   testcases/kernel/fs/fsstress/fsstress.c |   30 ++++++++++++++++--------------
>>   1 files changed, 16 insertions(+), 14 deletions(-)
>>
>> diff --git a/testcases/kernel/fs/fsstress/fsstress.c b/testcases/kernel/fs/fsstress/fsstress.c
>> index 1f11f6e..3df0ce5 100644
>> --- a/testcases/kernel/fs/fsstress/fsstress.c
>> +++ b/testcases/kernel/fs/fsstress/fsstress.c
>> @@ -375,21 +375,24 @@ int main(int argc, char **argv)
>>                         break;
>>                 }
>>         }
>> -        while ( (loopcntr<= loops) || (loops == 0) )
>> -        {
>> -               if (no_xfs&&  errtag) {
>> -                       fprintf(stderr, "error injection only works on XFS\n");
>> -                       exit(1);
>> -               }
>>
>> -               if (no_xfs) {
>> -                       int i;
>> -                       for (i = 0; ops+i<  ops_end; ++i) {
>> -                               if (ops[i].isxfs)
>> -                                       ops[i].freq = 0;
>> -                       }
>> +       if (no_xfs&&  errtag) {
>> +               fprintf(stderr, "error injection only works on XFS\n");
>> +               exit(1);
>> +       }
>> +
>> +       if (no_xfs) {
>> +               int i;
>> +               for (i = 0; ops+i<  ops_end; ++i) {
>> +                       if (ops[i].isxfs)
>> +                               ops[i].freq = 0;
>>                 }
>> -
>> +       }
>> +
>> +       make_freq_table();
>> +
>> +        while ( (loopcntr<= loops) || (loops == 0) )
>> +        {
>>                         if (!dirname) {
>>                         /* no directory specified */
>>                         if (!nousage) usage();
>> @@ -407,7 +410,6 @@ int main(int argc, char **argv)
>>                         maxfsize = (off64_t)MAXFSIZE32;
>>                 else
>>                         maxfsize = (off64_t)MAXFSIZE;
>> -               make_freq_table();
>>                 dcache_init();
>>                 setlinebuf(stdout);
>>                 if (!seed) {
>> --
>> 1.6.2.5
>>      
> Andrew,
>      Please use tabs instead of spaces for indentation. Run
> checkpatch.pl after everything's said and done to validate style.
> Thanks,
> -Garrett
>
> ------------------------------------------------------------------------------
> Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
> is the only developer event you need to attend this year. Jumpstart your
> developing skills, take BlackBerry mobile applications to market and stay
> ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
> http://p.sf.net/sfu/devconf
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
>
>    


------------------------------------------------------------------------------
Come build with us! The BlackBerry&reg; Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9&#45;12, 2009. Register now&#33;
http://p.sf.net/sfu/devconf
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list