public inbox for ltp@lists.linux.it
 help / color / mirror / Atom feed
From: liubo <liubo2009@cn.fujitsu.com>
To: ltp-list@lists.sourceforge.net
Subject: [LTP] [PATCH] mem/hugetlb: fix failure of hugemmap03
Date: Wed, 21 Oct 2009 11:52:11 +0800	[thread overview]
Message-ID: <4ADE856B.4030509@cn.fujitsu.com> (raw)

1)    In mmap's manual,
The starting address for the new mapping is specified in addr.

So, if mmap's argument "addr" is reachable, the mmap will
creates a new mapping in the virtual address space of the
call-ing process.
The test hugemmap03 will test that a normal page cannot
 be mapped into a high memory region. This infers that "addr"
should be higher for 64-bit mode.


2)    The test use "-I2" option, and this not only causes TFAIL's
loop, but also causes TPASS's loop.
For TFAIL, loop is deserved, nor for TPASS.

This patch fixed these problems.

Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>

---
 testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
index 892d24b..a07b9aa 100644
--- a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
+++ b/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c
@@ -55,7 +55,7 @@
 #include "usctest.h"
 
 #define PAGE_SIZE      ((1UL) << 12) 	/* Normal page size */
-#define HIGH_ADDR      (void *)(0x10000000000)
+#define HIGH_ADDR      (void *)(0x1000000000000)
 
 char* TEMPFILE="mmapfile";
 
@@ -130,6 +130,7 @@ main(int ac, char **av)
 			continue;
 		} else {
 			tst_resm(TPASS, "Normal mmap() into high region failed correctly");
+			break;
 		}
 
 		close(fildes);




------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

             reply	other threads:[~2009-10-21  3:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-21  3:52 liubo [this message]
2009-10-26 17:02 ` [LTP] [PATCH] mem/hugetlb: fix failure of hugemmap03 Subrata Modak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADE856B.4030509@cn.fujitsu.com \
    --to=liubo2009@cn.fujitsu.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox