From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-3.v28.ch3.sourceforge.com ([172.29.28.123] helo=mx.sourceforge.net) by 335xhf1.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1N5Fo0-0006tw-Pj for ltp-list@lists.sourceforge.net; Tue, 03 Nov 2009 09:36:00 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by 3b2kzd1.ch3.sourceforge.com with esmtp (Exim 4.69) id 1N5Fnr-0000PH-2i for ltp-list@lists.sourceforge.net; Tue, 03 Nov 2009 09:36:00 +0000 Message-ID: <4AEFF972.3080405@cn.fujitsu.com> Date: Tue, 03 Nov 2009 17:35:46 +0800 From: liubo MIME-Version: 1.0 References: <4AEFF53D.1010908@in.ibm.com> In-Reply-To: <4AEFF53D.1010908@in.ibm.com> Subject: Re: [LTP] [PATCH][RFC]Testcases mbind01.c and get_mempolicy01 fails with EINVAL List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0140392078504497757==" Errors-To: ltp-list-bounces@lists.sourceforge.net To: Sharyathi Nagesh Cc: "Rishikesh K. Rajak" , ltp-list@lists.sourceforge.net This is a multi-part message in MIME format. --===============0140392078504497757== Content-Type: multipart/alternative; boundary="------------090908070700060301070000" This is a multi-part message in MIME format. --------------090908070700060301070000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi On 11/03/2009 05:17 PM, Sharyathi Nagesh wrote: > Hi > We observed that LTP test cases are failing when run on some of > the distros > > Problem Statement: > > I observed that test cases mbind01.c and get_mempolicy01.c are > failing during call to get_mempolicy() with error -EINVAL. > In the kernel code the error comes from > ---------------------------------------------------------------- > > SYSCALL_DEFINE5(get_mempolicy, int __user *, policy, > unsigned long __user *, nmask, unsigned long, maxnode, > unsigned long, addr, unsigned long, flags) > { > int err; > int uninitialized_var(pval); > nodemask_t nodes; > > if (nmask != NULL && maxnode < MAX_NUMNODES) > return -EINVAL; > <== in the kernel code, > MAX_NUMNODES comes to 512 Is it better that "MAX_NUMNODES" get from configure file? For different platforms may have different MAX_NUMNODES. Regards-- Liu Bo > ---------------------------------------------------------------- > Analysis: > > When kernel config option 'configure maximum number of SMP > processors and NUMA node' is set MAX_NUMNODES will be initialized to > 512 and any call to get_mempolicy() with maxnode value less than that > cause the test to fail. > ---------------------------------------------------------------- > Fix: > increase the default maxnode value in the test case to reflect > this value. maxnode value comes from numaif.h and this patch increase > the value to 512 from earlier 128. > > Note: > I will submit it in the format, once the patch is accepted > > Thanks > Yeehaw > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------------ > Come build with us! The BlackBerry(R) Developer Conference in SF, CA > is the only developer event you need to attend this year. Jumpstart your > developing skills, take BlackBerry mobile applications to market and stay > ahead of the curve. Join us from November 9 - 12, 2009. Register now! > http://p.sf.net/sfu/devconference > ------------------------------------------------------------------------ > > _______________________________________________ > Ltp-list mailing list > Ltp-list@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ltp-list > --------------090908070700060301070000 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi

On 11/03/2009 05:17 PM, Sharyathi Nagesh wrote:
Hi
    We observed that LTP test cases are failing when run on some of the distros

Problem Statement:

    I observed that test cases mbind01.c and get_mempolicy01.c are failing during call to get_mempolicy() with error -EINVAL.
    In the kernel code the error comes from
----------------------------------------------------------------

SYSCALL_DEFINE5(get_mempolicy, int __user *, policy,
                unsigned long __user *, nmask, unsigned long, maxnode,
                unsigned long, addr, unsigned long, flags)
{
        int err;
        int uninitialized_var(pval);
        nodemask_t nodes;

        if (nmask != NULL && maxnode < MAX_NUMNODES)
                return -EINVAL;
                                                 <== in the kernel code,
MAX_NUMNODES comes to 512

  Is it better that "MAX_NUMNODES" get from configure file?

  For different platforms may have different  MAX_NUMNODES.


  Regards--
  Liu Bo

----------------------------------------------------------------
Analysis:
    
    When kernel config option 'configure maximum number of SMP processors and NUMA node'  is set MAX_NUMNODES will be initialized to 512 and any call to get_mempolicy() with maxnode value  less than that cause the test to fail.
----------------------------------------------------------------
Fix:
    increase the default maxnode value in the test case to reflect this value. maxnode value comes from numaif.h and this patch increase the value to 512 from earlier 128.

Note:
    I will submit it in the format, once the patch is accepted

Thanks
Yeehaw 



------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

--------------090908070700060301070000-- --===============0140392078504497757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference --===============0140392078504497757== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list --===============0140392078504497757==--