From: Shi Weihua <shiwh@cn.fujitsu.com>
To: Garrett Cooper <yanegomi@gmail.com>
Cc: ltp-list <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PROBLEM?] rt_sigaction01 still failed on x86_64
Date: Tue, 26 Jan 2010 17:34:35 +0800 [thread overview]
Message-ID: <4B5EB72B.7010909@cn.fujitsu.com> (raw)
In-Reply-To: <364299f41001260025v527adde4u44ff82c647d18b4e@mail.gmail.com>
at 2010-1-26 16:25, Garrett Cooper wrote:
> On Mon, Jan 25, 2010 at 11:54 PM, Garrett Cooper <yanegomi@gmail.com> wrote:
>> On Mon, Jan 25, 2010 at 9:45 PM, Shi Weihua <shiwh@cn.fujitsu.com> wrote:
>>> Hi, Cooper
>>>
>>> I noticed that you added a check of platform which not defined
>>> sa_sigaction in struct sigaction.
>>> http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01.c?r1=1.6&r2=1.7
>>>
>>> As your expectted, the following message will output on x86_64.
>>> ------------
>>> Your architecture doesn't support this test (no sa_sigaction field in struct sigaction).
>>> ------------
>>> But unfortunately, it still failed on my x86_64.
>>>
>>> On my x86_64, signal.h like this:
>>> ------------
>>> #ifndef __ASSEMBLY__
>>>
>>> #ifdef __i386__
>>> (sa_sigaction defined here) <--
>>> #else /* __i386__ */
>>> (no sa_sigaction defined) <--
>>> #endif /* !__i386__ */
>>>
>>> #endif /* __ASSEMBLY__ */
>>> ------------
>>> your check still work ? Sorry, I don't know the check process in
>>> LTP configure clearly. Could you give me some explanation.
>>
>> Shi,
>> I'm just going to test out the other proposed rt_sigaction, and
>> revert this change if it doesn't work back to a semi-functioning state
>> (which means that x86_64 will once again be broken).
>
> Files reverted because liubo's patch didn't stick.
Do you will pick out some useful code from liubo's patch ?
Previously, you said you would do that. (2009-12-22) ;-)
> Thanks,
> -Garrett
>
>
------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-01-26 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 5:45 [LTP] [PROBLEM?] rt_sigaction01 still failed on x86_64 Shi Weihua
2010-01-26 7:54 ` Garrett Cooper
2010-01-26 8:25 ` Garrett Cooper
2010-01-26 9:34 ` Shi Weihua [this message]
2010-01-26 16:43 ` Garrett Cooper
2010-02-22 1:41 ` liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5EB72B.7010909@cn.fujitsu.com \
--to=shiwh@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=yanegomi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox