From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sfi-mx-2.v28.ch3.sourceforge.com ([172.29.28.122] helo=mx.sourceforge.net) by sfs-ml-4.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1NeMhm-00078o-NY for ltp-list@lists.sourceforge.net; Mon, 08 Feb 2010 06:02:42 +0000 Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by sfi-mx-2.v28.ch3.sourceforge.com with esmtp (Exim 4.69) id 1NeMhk-0004Tw-W1 for ltp-list@lists.sourceforge.net; Mon, 08 Feb 2010 06:02:42 +0000 Message-ID: <4B6FA8F0.6050504@cn.fujitsu.com> Date: Mon, 08 Feb 2010 14:02:24 +0800 From: Shi Weihua MIME-Version: 1.0 Subject: [LTP] [PATCH] cap_bound: should to TBROK if f != CAP_SET in exec_without_inh.c List-Id: Linux Test Project General Discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-list-bounces@lists.sourceforge.net To: subrata@linux.vnet.ibm.com Cc: ltp-list An error occured on my i386 box. (OS: Fedora8, Kernel: 2.6.33-rc6, libcap: libcap-2.16) ------------- exec_without_inh 1 TFAIL : Failed to drop CAP_SYS_ADMIN from bounding set. exec_without_inh 0 TINFO : (ret=-1, errno 38) ------------- If the macro HAVE_DECL_CAP_BSET_DROP is 0, this error will occurs. But the program should to be broken when f != CAP_SET, like the similar code "if (ret || f != CAP_SET) {" in exec_with_inh.c. The TBROK message will be outputted if my patch merged. ------------- exec_without_inh 1 TBROK : Failed to add CAP_SYS_ADMIN to pI ------------- Signed-off-by: Shi Weihua --- --- testcases/kernel/security/cap_bound/exec_without_inh.c.orig 2010-02-08 11:54:22.000000000 -0500 +++ testcases/kernel/security/cap_bound/exec_without_inh.c 2010-02-08 11:55:00.000000000 -0500 @@ -80,6 +80,11 @@ int main(int argc, char *argv[]) tst_exit(); } } + else if (ret) { + tst_resm(TBROK, "Failed to add CAP_SYS_ADMIN to pI\n"); + tst_exit(); + } + #if HAVE_DECL_CAP_FREE cap_free(cur); #endif ------------------------------------------------------------------------------ The Planet: dedicated and managed hosting, cloud storage, colocation Stay online with enterprise data centers and the best network in the business Choose flexible plans and management services without long-term contracts Personal 24x7 support from experience hosting pros just a phone call away. http://p.sf.net/sfu/theplanet-com _______________________________________________ Ltp-list mailing list Ltp-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ltp-list