From: Subrata Modak <subrata@linux.vnet.ibm.com>
To: Iranna D Ankad <iranna.ankad@in.ibm.com>,
Rishikesh K Rajak <risrajak@in.ibm.com>
Cc: LTP <ltp-list@lists.sourceforge.net>,
Vishukumar S Shetty <svishuku@in.ibm.com>
Subject: Re: [LTP] [ANNOUNCEMENT]: Intermediate release for FEB'10
Date: Tue, 23 Feb 2010 11:01:03 +0530 [thread overview]
Message-ID: <4B836817.6030103@linux.vnet.ibm.com> (raw)
In-Reply-To: <364299f41002221017y4b49a212qd81ebc248d4b89d2@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1929 bytes --]
Garrett Cooper wrote:
> On Mon, Feb 22, 2010 at 8:49 AM, Rishikesh K Rajak
> <risrajak@linux.vnet.ibm.com> wrote:
>
>> Hi Iranna,
>>
>>
>> Thanks for reporting this build failure and helping, as it will
>> really help to make ltp more stable.
>>
>> Here is the quick patch i am attaching which solves the problem.
>>
>> Signed-off By: Rishikesh K Rajak<risrajak@linux.vnet.ibm.com>
>> Tested By: Rishikesh K Rajak<risrajak@linux.vnet.ibm.com>
>> ---
>> diff --git a/testcases/kernel/syscalls/mbind/mbind01.c
>> b/testcases/kernel/syscalls/mbind/mbind01.c
>> index 5d7eb69..847186a 100644
>> --- a/testcases/kernel/syscalls/mbind/mbind01.c
>> +++ b/testcases/kernel/syscalls/mbind/mbind01.c
>> @@ -74,6 +74,7 @@ int TST_TOTAL = 2; /* total number of tests
>> in this file. */
>> #include <unistd.h>
>> #include "include_j_h.h"
>> #include "numa_helpers.h"
>> +#include <linux/mempolicy.h>
>>
And also, including <linux/*.h> in any application(s) other than the
kernel itself is better avoided.
Regards--
Subrata
>> #if ! defined(LIBNUMA_API_VERSION) || LIBNUMA_API_VERSION < 2
>>
>
> No. This patch shouldn't be committed because of namespace collisions
> between numa and mempolicy (thank the developers for just copy-pasting
> constants, macros, etc instead of properly requiring numa on the
> target system in order for mempolicy to work...).
>
> Thanks,
> -Garrett
>
> ------------------------------------------------------------------------------
> Download Intel® Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
[-- Attachment #1.2: Type: text/html, Size: 3069 bytes --]
[-- Attachment #2: Type: text/plain, Size: 345 bytes --]
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
[-- Attachment #3: Type: text/plain, Size: 155 bytes --]
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2010-02-23 5:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-22 7:47 [LTP] [ANNOUNCEMENT]: Intermediate release for FEB'10 Rishikesh
2010-02-22 15:48 ` Iranna D Ankad
2010-02-22 16:49 ` Rishikesh K Rajak
2010-02-22 18:17 ` Garrett Cooper
2010-02-23 5:31 ` Subrata Modak [this message]
2010-02-22 18:15 ` Garrett Cooper
2010-02-23 6:41 ` Iranna D Ankad
2010-02-23 6:52 ` Garrett Cooper
2010-02-23 7:01 ` Garrett Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B836817.6030103@linux.vnet.ibm.com \
--to=subrata@linux.vnet.ibm.com \
--cc=iranna.ankad@in.ibm.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=risrajak@in.ibm.com \
--cc=svishuku@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox